Commit Graph
87135 Commits
Author SHA1 Message Date
Hervé Poussineau dca369cf41 [WIN32SS:ENG] Rework EngpUpdateGraphicsDeviceList
- choose VGA adapter outside of driver initialization loop
- choose primary adapter outside of driver initialization loop
- link VGA adapter to primary adapter at the end
- only set DISPLAY_DEVICE_PRIMARY_DEVICE in this function

Also mark VgaSave driver as SystemStart instead of Disabled,
so it is available if main display driver doesn't work.
2025-05-12 18:24:55 +02:00
Katayama Hirofumi MZ 6df1cc63b6 [BROWSEUI] Fix 'bad window handle' on CShellBrowser::RepositionBars (#7980)
Silence "NtUserSetWindowPos bad window
handle!" error at win32k!NtUserSetWindowPos
function when Desktop has started up.
JIRA issue: CORE-19663
Add null check of window handle before
SetWindowPos call in
CShellBrowser::RepositionBars method.
2025-05-12 22:27:52 +09:00
Katayama Hirofumi MZ d06d9f3e8f [SYSDM] Improve Japanese (ja-JP) translation (#7976)
JIRA issue: CORE-18706
Update dll/cpl/sysdm/lang/ja-JP.rc.
2025-05-11 21:57:55 +09:00
Katayama Hirofumi MZ 6a905ae2e1 [REACTOS] Improve Japanese (ja-JP) translation (#7975)
JIRA issue: CORE-18706
Update base/setup/reactos/lang/ja-JP.rc.
2025-05-11 21:57:07 +09:00
Eric Kohl d32fd58722 [UMPNPMGR][ADVAPI32][SERVICES] Pass PNP events to the service manager
- umpnpmgr.dll: Call I_ScSendPnPMessage to report pnp events to the service manager.
- adavpi32.dll: Implement I_ScSendPnPMessage which calls the service managers RI_ScSendPnPMessage function.
- services.exe: Add a debug message to RI_ScSendPnPMessage.
2025-05-11 14:25:15 +02:00
Katayama Hirofumi MZ 00b5dc8b49 [BROWSEUI] Quick Launch: Refresh buttons on change notify (#7965)
Respond change notification on Quick Launch.
JIRA issue: CORE-18475
- Subclass CISFBand to handle messages.
- Register change notification.
- Refresh buttons on change notification.
- Use timer to reduce redrawing cost.
2025-05-11 06:04:14 +09:00
Whindmar Saksit afe29ee7fa [BROWSEUI] Don't remember invoked non-folders in addressbar (#7954)
CORE-20091
2025-05-09 16:19:49 +02:00
Eric Kohl e0ef51b11e [UMPNPMGR] PNP_RegisterNotification: Validate a service and keep its status handle in the notification entry 2025-05-09 01:00:59 +02:00
Hervé Poussineau 3729b96625 [WIN32SS:ENG] In case of error, display the name of the problematic file 2025-05-08 21:48:14 +02:00
Hervé Poussineau a8abe1d677 [WIN32SS:ENG] Move debug log to the right place
Display number of prepared modes after preparing them, not at device creation
where this number is always 0.
2025-05-08 21:48:14 +02:00
Hervé Poussineau a36bf31a0d [VGAMP] Correctly initialize interface before calling VideoPortInitialize 2025-05-08 21:48:14 +02:00
Hermès Bélusca-Maïto f20efc6007 [INCLUDE][ATL] Fix WM_SETHOTKEY macro wrappers
WM_SETHOTKEY / WM_GETHOTKEY messages encode the hotkey in a different
way than with the WM_HOTKEY message.
For more details, see:
https://learn.microsoft.com/en-us/windows/win32/inputdev/wm-gethotkey
https://learn.microsoft.com/en-us/windows/win32/inputdev/wm-sethotkey

Addendum to commit 6829350af9 (PR #7947)
2025-05-08 18:57:43 +02:00
Eric Kohl 3bb27eb416 [UMPNPMGR] Fix buggy identification of window and service handles 2025-05-07 23:57:09 +02:00
Katayama Hirofumi MZ 0ca6002b4f [GDI32][NTGDI][SDK] Font/Text: Fix SAL2 annotations and const-ness (#7865)
I want to work in correct type info.
JIRA issue: CORE-17684
- Add and fix SAL2 annotations.
- Fix const-ness of function
  parameters.
- Delete needless type casts.
2025-05-06 15:13:04 +09:00
Katayama Hirofumi MZ 530d26a1f4 [NTGDI][NTUSER] Initial support of NtGdiRemoveFontResourceW (#7877)
Enable the users to delete fonts.
JIRA issue: CORE-17684
- Add IntDeleteRegFontEntry helper function.
- Add RegDeleteValueW and RegEnumValueW helper
  functions in win32ss/user/ntuser/misc/registry.c.
- Add some code to IntGdiRemoveFontResourceSingle
  function.
2025-05-06 12:38:54 +09:00
Katayama Hirofumi MZ 2c475add8c [IMM32][NETAPI32][SDK] Reduce Wine dependency (#7912)
Related to #7870. netapi32.dll uses NDK.
So, we have to reduce dependency on Wine.
JIRA issue: CORE-5743
- Introduce wine2ros module in
  sdk/lib/wine2ros/.
- Reduce Wine dependency.
2025-05-06 09:59:47 +09:00
Dmitry Borisov 45b928f8bc [ACPI] Remove section assignment from IOCTL handlers (#7829)
Fix a bug introduced in 5070e8960a.

CORE-17256

- These handlers must be memory resident. Otherwise,
  this would cause a page fault that needs to be resolved.
  Low-level storage drivers could evaluate ACPI control
  methods while the device's IRP queue has been paused.

- Minor code enhancements.
2025-05-05 22:42:11 +02:00
Timo Kreuzer d1f9e06a4f [REACTOS] Change manifest architecture from "X86"/"" to "*" 2025-05-05 10:02:51 +00:00
Katayama Hirofumi MZ 93e9710caf [CRT_APITEST] Add setjmp testcase (Retry) (#7847)
Splitted from #7839. Improved a little.
JIRA issue: CORE-19265
2025-05-05 12:56:21 +09:00
Katayama Hirofumi MZ 7073bdfead [EXPLORER][SHELL32][SHELL32_APITEST][SDK] AppBar Part 2 (#7946)
Follow-up of #7778.
JIRA issue: CORE-7237
- Rename APPBARDATA3264 structure
  as APPBARDATAINTEROP.
- Fix structures for WoW64.
- Use trace instead of DPRINT1.
- Add CAppBarManager::
  RecomputeAllWorkareas function.
- Fix WM_DISPLAYCHANGE handling
  to re-compute the work areas.
2025-05-05 12:48:02 +09:00
Petru Răzvan 24c2e4433b [NETSHELL] Implement Right click menu (#7959)
This implements the right click menu on the network icon that is in the taskbar.

CORE-9055

Note that Repair isn't implemented and emits a "not implemented" message,
because as far as I see ReactOS has no repair functionality for internet.
2025-05-04 22:41:20 +02:00
Petru Răzvan 986c4778fa [REGEDIT] Fix Incorrect status bar (#7944)
This fixes the incorrect status bar that happens when context menu action is used.

CORE-19524
2025-05-04 22:38:21 +02:00
Mohammad Amin Mollazadeh 2e7cfa0400 [WINESYNC][COMCTL32] Move caret to the end on "select all" (#7939)
CORE-19903

comctl32/edit: Scroll caret on Ctrl+A.

wine commit id https://github.com/wine-mirror/wine/commit/e71087cd39fdc546846f1f74f2e701596bcfd18d by Vladislav Timonin <[email protected]>
2025-05-04 22:32:56 +02:00
Petru Răzvan 2aa6fc1c7f [WORDPAD] Fix garbage in "Get Text" dialog (#7922)
This fixes the garbage in the "Get Text" dialog which occurs if there is no text input
and one clicks on "Get Text" under Extras.

CORE-19868
Reported to Wine: https://bugs.winehq.org/show_bug.cgi?id=58144
2025-05-04 22:28:32 +02:00
Eric Kohl 7c8a8400e0 [SDK][LSASRV][SETUPAPI] Move undocumented service manager functions into a new header file 2025-05-04 20:15:48 +02:00
Hermès Bélusca-Maïto fad52db479 [EVENTVWR] Add missing output buffer size parameters to some routines.
Fix also some bugs encountered while testing.
2025-05-04 17:54:28 +02:00
Marcin Jabłoński 39ce22150a [DESK][SHELL32] Remove desk.cpl hacks for argument parsing (#7934)
Remove argument parsing hacks from desk.cpl that were originally introduced to
make it work with the previous broken implementation of `Control_RunDLLW`.

CORE-20076

- Remove argument parsing hacks from desk.cpl;
- Fix some issues with space separated string parsing in `Control_RunDLL`;
- Windows seems to allow invalid dialog-box names if there is only one dialog-box.
2025-05-04 17:47:28 +02:00
Eric Kohl 9638666d84 [MOUCLASS] Only set the device interface state if we have an interface name 2025-05-04 17:28:37 +02:00
Eric Kohl 5414600e1e [KBDCLASS] Set the device interface state on device start and device remove 2025-05-04 17:27:23 +02:00
Mohammad Amin Mollazadeh cc16769179 [SHELL32] Fix focus glitch when hovering separators with submenu open (#7932)
CORE-20124

Since `TB_HITTEST` returns negative numbers for ID for separator menu items [^1],
shell menu assumes mouse moved outside of the menu popup, highlighting the menu
item for currently open submenu.
To fix this behavior, we can detect separators in `CMenuFocusManager::ProcessMouseMove`
and negate the ID returned by `TB_HITTEST` to make it a positive number again,
so the shell menu wouldn't glitch.

[^1]: https://learn.microsoft.com/en-us/windows/win32/controls/tb-hittest
2025-05-04 17:11:44 +02:00
Mohammad Amin Mollazadeh 3e342246d4 [WINESYNC][COMCTL32] Fix large height for ComboBox when CBS_NOINTEGRALHEIGHT is specified (#7940)
CORE-19833

wine commit id https://github.com/wine-mirror/wine/commit/d551564f1b626b508583149be515b2111ec020b0 by Orin Varley <[email protected]>

comctl32: Make CBS_NOINTEGRALHEIGHT only set minimum combobox height.

When the combobox height is to be set by the application (as the CBS_NOINTEGRALHEIGHT style is on),
and when a large size is specified but only a small number of items in the list, the height of the
combobox should be set by the number of items rather than the size specified to avoid empty lines.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57360
2025-05-04 16:59:54 +02:00
Timo Kreuzer 946f17e93d [NTOS] Fix x64 definition of MMPFN
Adjust the definition of COLORED_LIST_HEAD to always match the new MI_PTE_FRAME_BITS define.
2025-05-04 07:28:41 +00:00
Timo Kreuzer fb8e6124e0 [NDK][XDK] Update definition of KUSER_SHARED_DATA with tests 2025-05-04 07:24:40 +00:00
Mohammad Amin Mollazadeh 21d3e290b7 [WINESYNC][COMCTL32] Don't delete font when destroying the control (#7941)
The font object `infoPtr->Font` is not owned by the `syslink` control, therefore freeing it would make the whole system use a different font. The fix provided by Wine removes the code that deletes this font object.

Imports Wine commit https://github.com/wine-mirror/wine/commit/480598680ceb86661bd269b7a64bd90e38a40f98

Fixes deleting system font object when destroying syslink. CORE-20127
2025-05-04 02:14:24 +03:00
Tim Abdiukov a9ba54f678 [DWNL] Improve user experience and fix progress output (#7903)
- `CBindStatusCallback_UpdateProgress`:
  * Rework the failsafe check to enable percentage to be at 100%.
  * More thorough failsafe check, to avoid displaying 100% (or even 101%) where the actual and expected file sizes don't match.
- `case BINDSTATUS_ENDDOWNLOADDATA`: Do update the progress one last time to be at 100%, on download success.
2025-05-03 23:42:36 +02:00
Hermès Bélusca-Maïto e6f5065f32 [EVENTVWR] Rewrite the way data is copied into the clipboard
CORE-20023

- Besides copying the event information, copy also its formatted data.

- Update translations with new IDS_COPY* strings.

- Eliminate all statically-sized temporary buffers, in favour of
  carefully calculating the size, and allocating an adequately
  sized buffer to hold the data to be copied.

- By default, the "title" and event info on the single-line fields,
  are separated with TABs (to facilitate data import in spreadsheets).
  Add a mode where, when the user presses the SHIFT key while clicking
  on the "Copy" button, the separation is instead done with space
  padding, to be able to prettify information display when copying
  into text files instead.
2025-05-03 17:15:29 +02:00
Hermès Bélusca-Maïto 85a69768d0 [EVENTVWR] DisplayEvent(): Avoid using multiple large statically-sized buffers
CORE-20023

And use a loop to fill the individual event item fields,
instead of repeating the same code over and over.
2025-05-03 17:15:18 +02:00
Whindmar Saksit 6829350af9 [SHELL32][NTUSER] Implement the SEE_MASK_HOTKEY/ICON/HMONITOR flags (#7947) 2025-05-03 16:08:58 +02:00
Timo Kreuzer 102c1db735 [NTDLL_APITEST] Fix x64 MSVC warnings 2025-05-03 08:01:03 +00:00
Timo Kreuzer 7af8ab2470 [NTDLL_APITEST] Add a test for NtQuerySection 2025-05-03 08:01:03 +00:00
Timo Kreuzer 4cee67df3f [CMAKE] Fix TREAT_ALL_WARNINGS_AS_ERRORS 2025-05-03 08:00:44 +00:00
Timo Kreuzer 2d57c60148 [WINMM] Silence MSVC warning about unary minus operator
mci.c(1012): warning C4146: unary minus operator applied to unsigned type, result still unsigned
2025-05-03 08:00:44 +00:00
Timo Kreuzer edc8eb63c4 [RICHED20] Fix array bounds overflow
editor.c(4518): warning C4045: 'text': array bounds overflow
2025-05-03 08:00:44 +00:00
Timo Kreuzer 9bfa6b51be [BROWSEUI] Fix MSVC warning about unary minus operator
basebarsite.cpp(536): warning C4146: unary minus operator applied to unsigned type, result still unsigned
2025-05-03 08:00:44 +00:00
Doug Lyons e98bba2535 [NTGDI:FREETYPE] Fix Fonts broken by opening VLC About (Retry of PR #4579) (#7952)
* Check is FontGDI->OriginalWeight > FontGDI->RequestWeight and if so, then return original weight.
* Do not handle FontGDI->OriginalWeight as a boolean. Use 'FontGDI->OriginalWeight = FW_DONTCARE;'.

CORE-17011
2025-05-01 17:44:10 -05:00
Whindmar Saksit bbd6a57c0f [MSGINA][LSASRV] Support LSA secret DefaultPassword in autologon (#7936) 2025-05-01 17:51:42 +02:00
Stanislav Motylkov 21810f11e4 [REGEDIT] Update Russian (ru-RU) translation
Addendum to eb91f91569. CORE-19886
2025-05-01 16:36:11 +03:00
Marcin Jabłoński b79a0447b9 [REGEDIT] Update Polish (pl-PL) translation (#7949)
Addendum to eb91f91569. CORE-19886
2025-05-01 16:26:33 +03:00
Katayama Hirofumi MZ d722e70817 [SDK][USER32] Implement WM_IME_SYSTEM.IMS_SOFTKBDONOFF (#7950)
Supporting soft keyboard will improve IME
usability.
JIRA issue: CORE-19268
- Define IMS_SOFTKBDONOFF constant as
  0x13 in <immdev.h>.
- Implement
  WM_IME_SYSTEM.IMS_SOFTKBDONOFF
  message handling in ImeWnd_OnImeSystem.
2025-05-01 11:20:18 +09:00
Katayama Hirofumi MZ e40e5f572f Revert "[COMCTL32] Pager: Fix PGM_RECALCSIZE behaviour (#7875)" (#7910)
Reverts #7875.
JIRA issue: CORE-20121
2025-04-30 20:38:22 +09:00