Commit Graph
87866 Commits
Author SHA1 Message Date
Hermès Bélusca-Maïto c7d4040767 [FREELDR] ArcGetFileInformation(): Set Information->FileName, Length, and Attributes for filesystems (#8420)
CORE-9023

Add support for all the supported filesystems: FAT/FATX, NTFS,
ISO, EXT, BTRFS, as well as for files loaded via PXE.

arc.h:
- Add `FILEATTRIBUTES` enumeration;
- Remove non-existing `CreateReadOnly` and `SupersedeReadOnly`
  `OPENMODE` values; add missing `CreateReadWrite`.
2025-10-19 22:38:30 +02:00
Hermès Bélusca-Maïto eec9ca1305 [FREELDR] fs.c: Fix path device name lookup
Suppose the list of devices contains, for example listed in this order:

  `multi(0)disk(0)rdisk(0)partition(1)`,
followed by:
  `multi(0)disk(0)rdisk(0)`,

then if someone attempts to open `multi(0)disk(0)rdisk(0)`, the code
would erroneously open `multi(0)disk(0)rdisk(0)partition(1)` instead.

Device name lookup now verifies that the device name being tested has
the same length as the one being opened.

Noticed by user "Xen", see:
https://reactos.org/forum/viewtopic.php?p=144840#p144840
> Wrong name comparison in ArcOpen (can open "device()partition()"
> instead of "device()" that was really requested)
2025-10-19 21:23:12 +02:00
Hermès Bélusca-Maïto ad10c08b3d [SCSIPORT] Fix "Targed" typo 2025-10-19 17:13:51 +02:00
Hermès Bélusca-Maïto b51789c28d [FREELDR] scsiport.c: Set the Information->Type field (#8418)
CORE-9023

And more accurately detect and report disks:
using `InquiryBuffer.DeviceType`, differentiate between "rigid" disks,
floppy disks, and CD-ROM drives.
2025-10-19 17:13:50 +02:00
Hermès Bélusca-Maïto 246f2d29db [FREELDR] ArcGetFileInformation(): Set the Information->Type field for devices (#8418)
CORE-9023

Some of this determination is platform-specific (e.g. BIOS-based PC vs.
NEC PC-98 vs. Xbox), and is done in a per-platform `DiskGetConfigType()`
routine.
This routine is then invoked by `hwdisk.c!DiskOpen()` and `PcInitializeBootDevices()`.
2025-10-19 17:13:49 +02:00
Hermès Bélusca-Maïto e969fbeea8 [UDFS] Add missing NTAPI for PIO_APC_ROUTINE (#8417) 2025-10-19 17:11:55 +02:00
Hermès Bélusca-Maïto 79a9fcbbe7 [ROSTESTS:TESTS] Don't need the PIO_APC_ROUTINE cast (#8417) 2025-10-19 17:11:54 +02:00
Hermès Bélusca-Maïto 78362c1afa [PSDK] Update our icmpapi.h header; make it compatible with official PSDK (#8417)
- Add missing definitions in icmpapi.h and use SAL2 annotations;

- Rename `__WINE_ICMPAPI_H` to the official `_ICMP_INCLUDED_`;

- Use `NTDDI_VERSION` versioning for some funtions;

- Use `PIO_APC_ROUTINE_DEFINED` for the `ApcRoutine` parameter
  of the `Icmp*SendEcho2*()` functions, allowing to use the proper
  `PIO_APC_ROUTINE` type instead of `FARPROC`;

- Add missing Vista SP1+ `IcmpSendEcho2Ex()` function.
2025-10-19 17:11:53 +02:00
Hermès Bélusca-Maïto de1fb41750 [PSDK][NDK] winternl.h, iotypes.h: define PIO_APC_ROUTINE_DEFINED (#8417)
Define `PIO_APC_ROUTINE_DEFINED` after the `PIO_APC_ROUTINE` callback
type definition. Used by icmpapi.h `Icmp*SendEcho2*()` routines.
2025-10-19 17:11:52 +02:00
Hermès Bélusca-Maïto 73fb345877 [PSDK][INCLUDE/WINE] Import wine-10.0 icmpapi.h (#8417) 2025-10-19 17:11:04 +02:00
Mohammed al-Ramadany 03f4387231 [KMTEST] ExHardError and RtlCaptureContextKM fixes (#8342)
- Adjust expected values according to NT version and architecture
2025-10-18 09:28:59 -05:00
Timo Kreuzer 7e6e327581 [NTOS:SE] Fix handle leak on failure in SepOpenThreadToken 2025-10-18 15:14:14 +03:00
Timo Kreuzer 8eff6dfb77 [NTOS] Don't dereference the object when ObInsertObject fails
See CORE-17904
2025-10-18 15:14:14 +03:00
Timo Kreuzer 72b98da684 [NTOS:EX] Fix bugs in NtCreateEvent
- Validate EventType
- Cleanup on failure
- Add ASSERTs in KeInitializeEvent and KeInitializeTimerEx
2025-10-18 15:14:14 +03:00
Timo Kreuzer 804fdad3e0 [NTDLL_WINETEST] Fix prototype for NtCreateEvent
Fixes a number of tests on Windows.
2025-10-18 15:14:14 +03:00
Timo Kreuzer 02af7e7ecb [CRT_APITEST] Fix tests for wctomb
- Dynamically load function from the appropriate DLL
- Remove from ntdll_apitest (these are not exported by ntdll)
2025-10-18 15:12:19 +03:00
Timo Kreuzer 5272cc27d6 [CRT_APITEST] Fix tests for sprintf
- Dynamically load function from the appropriate DLL
- Fix tests for crtdll and user32
2025-10-18 15:12:19 +03:00
Timo Kreuzer ba592dad5d [CRT_APITEST] Fix tests for _vs(c/n)(w)printf
- Dynamically load function from the appropriate DLL
- Fix tests for ntdll/crtdll
2025-10-18 15:12:19 +03:00
Timo Kreuzer e1f843b929 [CRT_APITEST] Fix tests for _sn(w)printf
- Dynamically load function from the appropriate DLL
- Fix a test for crtdll
2025-10-18 15:12:19 +03:00
Eric Kohl 4df8fbf9c2 [NETSH] Add a special code path to execute commands that follow the pushd command
This enables the execution of commands like 'pushd interface ip' which is emitted by the dump command of WinXPs ifmon.dll.
2025-10-18 01:37:51 +02:00
Carl J. Bialorucki 6762703ce4 [PSDK][INCLUDE/WINE] Introduce our own shlwapi.h for PSDK and import wine-10.0 shlwapi.h for Wine code (#8419)
- [PSDK] Introduce our own Microsoft compatible and MIT-licensed shlwapi.h and fix breaking changes
- [INCLUDE/WINE] Import shlwapi.h from wine-10.0 for use with Wine compatible code
- [CMAKELISTS.TXT] Bump up IE version from IE60 to IE60SP2. This is required because we are already using IE60SP2 guarded functionality; the new header unhides this.
- [SHLWAPI] Fix breaking changes, including a typo for 'SHGVSPB_GLOBALDEAFAULTS' (should be 'SHGVSPB_GLOBALDEFAULTS')
- [MSI] Use wine's shlwapi.h instead of our own in automation.c, don't precompile shlwapi.h.
- [URLMON_WINETEST] Primarily use wineheaders for this test
2025-10-17 09:23:31 -05:00
Eric Kohl bfee65f62c [NETSH] Implement MakeQuotedString() and FreeQuotedString()
These functions are used by WinXPs ifmon.dll.
2025-10-17 15:12:44 +02:00
Eric Kohl 78a73720cc [NETSH] Fix help output
- Increase the output buffer for context and group help texts.
- Use a heap buffers to load and format the command help texts.
- Pass the full command name to FormatMessage to make help output work with WinXP helpers.
- Adjust the internal help texts accordingly.
2025-10-17 12:45:28 +02:00
Eric Kohl d1cbb29008 [KBDGRE1] Finish the German Extended (E1) keyboard layout
Add the missing dead key translations.
2025-10-17 10:55:30 +02:00
Eric Kohl 38afa1a48f [NETSH][REACTOS] Implement and export NsGetFriendlyNameFromIfName
Running the 'interface ip show address' command on XPs ifmon.dll now fails in netcfgx.dll.
2025-10-16 14:19:11 +02:00
Eric Kohl ac4d7351f9 [IPHLPAPI][REACTOS] Add iphlpapi_undoc.h and add undocumented functions
Add NhGetInterfaceNameFromDeviceGuid() and NhGetInterfaceNameFromGuid().
2025-10-16 13:20:00 +02:00
Eric Kohl 538468326d [NETCFGX] Implement INetCfgClass_fnFindComponent() and INetCfgClass_fnEnumComponents() 2025-10-15 22:54:57 +02:00
Eric Kohl 16e711b793 [NETCFGX][PSDK] Add missing parameter to INetCfgClass:FindComponent() 2025-10-15 19:40:25 +02:00
Eric Kohl e82663c9cd [KBDGRE1] More dead key translations for the German Extended (E1) Keyboard Layout 2025-10-15 12:27:59 +02:00
Eric Kohl d1bcef7485 [KBDGR1] Fix the keyboard description of the German IBM keyboard layout 2025-10-15 10:43:43 +02:00
Eric Kohl 82aaf15654 [IFMON] Implement a basic dump functionality 2025-10-14 17:19:00 +02:00
Eric Kohl d033301772 [NETSH] Sort sub-contexts in the help command 2025-10-14 15:11:28 +02:00
Hermès Bélusca-Maïto 5ce7d88397 [FREELDR] iso.h: Code doesn't use BIOS-specific DriveNumber
Addendum to commit e307cb2881 (r42528)
2025-10-14 14:15:48 +02:00
Václav Zouzalík af25f1d9b7 [BUTTERFLIES] Add Czech (cs-CZ) translation (#8412) 2025-10-14 14:15:00 +02:00
Eric Kohl 7715046ae3 [IPHLPAPI] Implement NhpAllocateAndGetInterfaceInfoFromStack
NhpAllocateAndGetInterfaceInfoFromStack is used by WinXPs ifmon.dll.
2025-10-14 09:59:10 +02:00
Hermès Bélusca-Maïto 21fc5cd20f [INCLUDE] arc.h: CONFIGTYPE in the FILEINFORMATION structure, is actually CONFIGURATION_TYPE 2025-10-13 22:13:33 +02:00
Andrei-Valentin Miloiu 81ebd7e162 [SHELL32] Update Romanian (ro-RO) translation (#8385) 2025-10-13 20:55:06 +02:00
Matisse RüdigerandHermès BÉLUSCA - MAÏTO 3055cc5f1a [SYSDM] Fix missing word in the French (fr-FR) translation (#8251)
Fix static text dimensions is enough to make it fit in the dialog.

Co-authored-by: Hermès BÉLUSCA - MAÏTO <[email protected]>
2025-10-13 20:51:55 +02:00
Václav Zouzalík 813bf225da [CIRCLES] Add Czech (cs-CZ) translation (#8414) 2025-10-13 20:29:45 +02:00
Václav Zouzalík 407594801b [BLANKSCR] Add and update Czech (cs-CZ) and Slovak (sk-SK) translations (#8411) 2025-10-13 20:28:03 +02:00
Václav Zouzalík 1518b9e228 [RAPPS] Update Czech (cs-CZ) translation (#8408) 2025-10-13 20:26:58 +02:00
Eric Kohl 9fa8028ae4 [UMPNPMGR] Fix RunningOnLiveMedium according to Hermes' suggestions
Note: Running a program on a LiveCD is not the same as running it in setup mode.
2025-10-13 17:05:43 +02:00
Eric Kohl 92b8ca8eab [IPHLPAPI] Fix GetAdaptersAddresses
- Simplify the way unicast addresses are returned
- Return proper prefix addresses
2025-10-12 18:18:12 +02:00
Eric Kohl af0c2e703b [PSDK][NETSH] Improve netsh.h 2025-10-12 00:54:10 +02:00
Eric Kohl fb2a0d1647 [NETSH] Implement the dump command 2025-10-11 22:40:24 +02:00
Eric Kohl 3cdc3d1652 [NETSH] Print the commands help text if a command returns ERROR_SHOW_USAGE 2025-10-11 15:23:15 +02:00
Doug Lyons ad6cb32fa5 [NTGDI] Fix 3D-text screensaver not moving in preview mode (#8402)
Thanks, @I_Kill_Bugs for the fix.
CORE-5601
2025-10-10 15:59:13 -05:00
Mikhail Tyukin 0172338964 [USER32] Fix pointer truncation (#8421)
Fix `UnregisterDeviceNotification()` crash on x64 due to pointer truncation.
Change signature of `CMP_REGNOTIFY` and `CMP_UNREGNOTIFY` to be correct (use `HDEVNOTIFY` instead of `ULONG`).
2025-10-10 20:43:34 +02:00
Eric Kohl 1b2272a5e5 [KBDGRE1] Update German Extended (E1) keyboard layout
- Fix the Shift-Ctrl-Alt modifier key layer.
- Add/update missing keys.

Most dead key translations are still missing.
2025-10-10 17:37:00 +02:00
Eric Kohl 5adcaf2b02 [KBDFR] Fix dead keys
The french (legacy) keyboard layout has got only four dead keys.
- Remove the unused dead key translations.
- Add the missing dead key name and convert the dead key names to upper case.

CORE-9381
2025-10-10 17:16:31 +02:00