Commit Graph
69177 Commits
Author SHA1 Message Date
Mark Jansen 116dfc5bd7 [SHIMLIB] Add debug print functionality for shims. CORE-11329
svn path=/trunk/; revision=75358
2017-07-16 13:50:23 +00:00
Mark Jansen 9215c5efc4 [ACPPAGE] Usability: Convert the edit box to a combobox, ask the user if they want to add the layer when closing the dialog.
svn path=/trunk/; revision=75357
2017-07-16 13:47:16 +00:00
Mark Jansen e41b7d9270 [SHELL32] Do not dereference a nullpointer for logging. CORE-13552
svn path=/trunk/; revision=75356
2017-07-16 13:44:18 +00:00
Sylvain Petreolle 21fc538caa Patch by Serge Gautherie:
[BOOTDATA]
hivesys.inf: Put 'Mup' service back in 'File System' group. (Fix r72450)
Fixes installation of Vmware Tools which was always hanging.
CORE-12107 #resolve


svn path=/trunk/; revision=75355
2017-07-16 13:37:29 +00:00
Pierre Schweitzer 13ae1129e5 [RDBSS]
Complementary to r75353: implement RxCancelNotifyChangeDirectoryRequestsForFobx()

CORE-11327

svn path=/trunk/; revision=75354
2017-07-15 11:41:24 +00:00
Pierre Schweitzer 8f00170a93 [RDBSS]
Implement RxNotifyChangeDirectory(), RxLowIoNotifyChangeDirectoryCompletion(), RxCancelNotifyChangeDirectoryRequestsForVNetRoot()

This means the first parts of the directory watch are here. Though, NFS driver doesn't support these, but at least, it reduces the UNIMPLEMENTED spam!

CORE-11327

svn path=/trunk/; revision=75353
2017-07-15 10:05:32 +00:00
Giannis Adamopoulos 0c134b04f8 [SHELL32] -Move CFSExtractIcon_CreateInstance to CFSFolder.cpp
svn path=/trunk/; revision=75352
2017-07-15 09:38:45 +00:00
Mark Jansen e12241f5a1 [USBPORT] Fix incorrect transfer direction for URBs. Patch by Vadim Galyant. CORE-13546
svn path=/trunk/; revision=75351
2017-07-15 09:24:30 +00:00
Giannis Adamopoulos c343d309f2 [SHELL32]
- CDesktopFolder: Create the enumerators of the internal fs folders and add their items in its own list instead of calling CreateFolderEnumList which enumerates ... files.
- Remove CEnumIDListBase::CreateFolderEnumList and move its code to CFileSysEnum::Initialize.

svn path=/trunk/; revision=75350
2017-07-15 09:18:06 +00:00
Pierre Schweitzer 9f3cbac23f [SHELL32]
In case a FSD doesn't support directory changes notifications, don't try to requeue a notification each time it returns 0 data.
Just quit instead.

CORE-13549

svn path=/trunk/; revision=75349
2017-07-15 07:48:47 +00:00
Pierre Schweitzer c4689f7e1d [SHELL32]
Avoid double-free and use-after-free in case the FSD fails to register the change directory notification

CORE-13549

svn path=/trunk/; revision=75348
2017-07-15 07:45:28 +00:00
James Tabor 47ade62a62 [ENG]
- Patch by Katayama Hirofumi MZ : Add counts to path data. See CORE-13536.

svn path=/trunk/; revision=75347
2017-07-15 03:58:42 +00:00
Hermès Bélusca-Maïto f6dbb71053 [USETUP]: Also adapt the INFCONTEXT structure here.
svn path=/trunk/; revision=75344
2017-07-14 22:17:12 +00:00
Hermès Bélusca-Maïto 882901c398 [INFLIB][FREELDR]: Introduce a (non-used) "CurrentInf" field in the INFCONTEXT structure, to make it compatible with the "standard" one defined in setupapi.h, so that it can be possible to either use our inflib or setupapi.dll in our code.
This will break build inside usetup, and this will be fixed in the next commit.

svn path=/trunk/; revision=75343
2017-07-14 22:15:48 +00:00
Mark Jansen 39596fae98 [APPHELP_APITEST] Convert test_match_ex to a data driven test + fix a bug in the apitest.
svn path=/trunk/; revision=75342
2017-07-14 20:35:11 +00:00
Mark Jansen 9f1e4379e0 [SPOOLSS] Stub BuildOtherNamesFromMachineName as seen in wine commit cdb5f35. This fixes a crash in spoolss:spoolss
svn path=/trunk/; revision=75341
2017-07-14 20:05:27 +00:00
Mark Jansen ae49e29351 [APPCOMPAT] Various fixes.
- Simplify shimdbg output as suggested by Thomas
- Simplify media/sdb/sysmain.xml
- Fix some warnings + a debug print

svn path=/trunk/; revision=75340
2017-07-14 19:29:34 +00:00
Peter Hater eb6e21dd58 [ADNS] Add function to return number of DNS servers available for query.
[DNSAPI] Use newly added function to return without search if no DNS servers are available.
CORE-13441 #resolve

svn path=/trunk/; revision=75339
2017-07-14 16:05:31 +00:00
Hermès Bélusca-Maïto 0b6eedad3a [WIN32K]: Addendum to r75332 : fix variable usage without initialization error C4700 (certainly due to a copy-paste error), caught by MSVC compiler...
CORE-13536

svn path=/trunk/; revision=75337
2017-07-14 01:37:06 +00:00
Hermès Bélusca-Maïto 41f2eb6c3e [GETUNAME]: Translation update by Sergey Stopkin.
CORE-13222 #resolve

svn path=/trunk/; revision=75335
2017-07-14 00:40:31 +00:00
Hermès Bélusca-Maïto 00d7ab957b [CMAKE]: Correctly set valid PE image version numbers for the OS subsystem (GCC builds), and image and OS version numbers from the NT OS version ReactOS is based on.
svn path=/trunk/; revision=75333
2017-07-13 20:50:49 +00:00
James Tabor 899d12e786 [Eng]
- Implement PATHOBJ_Xxx service routines, see CORE-13536.

svn path=/trunk/; revision=75332
2017-07-13 19:34:49 +00:00
James Tabor e61d96aa6a [NtGDI]
- Update path structure for future use.

svn path=/trunk/; revision=75329
2017-07-13 17:30:15 +00:00
James Tabor deaa7df817 [Win32SS]
- Remove old GDI structure and use the new one.

svn path=/trunk/; revision=75326
2017-07-13 01:59:41 +00:00
Hermès Bélusca-Maïto be9a0afc1f [SHELL32]: Enable showing the sorting arrows in the sorting header column of shell folder listviews.
CORE-11776 #resolve

svn path=/trunk/; revision=75325
2017-07-13 00:21:32 +00:00
Hermès Bélusca-Maïto 6f2c13e4df [WELCOME]: Diverse improvements:
- Compute once, when loading the list of topics with their associated commands, their special arguments or starting paths. The computed values can then be used each time a topic command is invoked.
- Distinguish between runnable commands (aka. external executables or files to be started), and internal actions like <msg> and <exit>.
- I have recently discovered that Windows' welcome.exe could also use a custom (OEM) "welcome.ini" file, much like what we already supported: see http://i.imgur.com/Se3IoQN.png .
  To make ours backwards-compatible with Windows' one, rename the "Button" keyword into "MenuText", and introduce two new keywords "ConfigCommand" and "ConfigArgs" that specify respectively the command to be started
  and its associated arguments. We continue to support our "Action" keyword for specifying internal actions.
- Improve the loading of the localized resources from the INI files.
- Correctly print the ReactOS version text, at a correct position depending on whether the checked box is display or not.
- Simplify some StringCchCopy + StringCchCat calls into StringCchPrintf.
- Simplify the code that creates the different fonts to be used within the program.
- Use more readable resource ID names.

svn path=/trunk/; revision=75322
2017-07-12 22:16:50 +00:00
Mark Jansen d9827356db [WIN32SS] Fix EqualFamilyInfo function logic. Patch by Victor Martinez Calvo, modified by Katayama Hirofumi MZ.
CORE-13411 #resolve, CID 1411971

svn path=/trunk/; revision=75321
2017-07-12 18:40:49 +00:00
Giannis Adamopoulos 3841692020 [COMCTL32_APITEST] - Log the dwDrawStage when the NM_CUSTOMDRAW is received to make the test slightly more descriptive.
svn path=/trunk/; revision=75320
2017-07-12 12:17:05 +00:00
Thomas Faber 4c8e09598a [USBPORT]
Patch by Vadim Galyant:
- Improve variable naming
- Make more consistent use of constants

svn path=/trunk/; revision=75314
2017-07-09 21:05:58 +00:00
Giannis Adamopoulos 0e8444a310 [EXPLORER]
- CTrayWindow: Implement the IContextMenu interface. This will be used by the CBandSite to query the context menu of its site (the CTrayWindow) and add it in its context menu. 
- CTrayWindowCtxMenu: Use Shell_MergeMenus in QueryContextMenu and respect its parameters.

svn path=/trunk/; revision=75313
2017-07-09 20:57:01 +00:00
James Tabor 1c0aedce83 [ENG]
- Turn on GradientFill apply small hack fix to keep it out of a loop.
- Turning code off does not fix the code, 8 years later!

svn path=/trunk/; revision=75312
2017-07-09 18:06:24 +00:00
Hermès Bélusca-Maïto d2fc6e6ee2 [old_WORDPAD]: Fix typo (caught by user_trisquel).
svn path=/trunk/; revision=75311
2017-07-09 16:06:07 +00:00
Mark Jansen d88628173c [FONTS] Add substitutes for the System font, and remove a hack for the System font. Patch by Katayama Hirofumi MZ. CORE-9222
svn path=/trunk/; revision=75310
2017-07-09 15:06:49 +00:00
Pierre Schweitzer 36532bafeb [RDBSS]
Fix broken assignment.
Spotted by cppcheck.

svn path=/trunk/; revision=75309
2017-07-08 21:22:55 +00:00
Eric Kohl 994a9eced3 [NETAPI32]
- Add DsAddressToSiteNamesExA stub.
- Implement DsAddressToSiteNamesExW.

svn path=/trunk/; revision=75308
2017-07-08 21:07:29 +00:00
Pierre Schweitzer ae1901b2c3 [RXCE]
- Define RxShouldPostCompletion() and use it
- Define RxIsResourceOwnershipStateExclusive() and use it
- Define some magic values

[RDBSS]
- Implement CheckForLoudOperations(), RxAdjustFileTimesAndSize(), RxIsOkToPurgeFcb()
- Continue implementation of RxCommonCleanup()
- Fix bugs in the RxCommonCleanup() implementation and make it more explicit when in the delete on close path
- Stub RxCleanupPipeQueues(), RxLowIoLockControlShell()
- Silent a few DPRINTs

CORE-8204
CORE-11327

svn path=/trunk/; revision=75307
2017-07-08 17:12:33 +00:00
Eric Kohl f45220c16f [NETAPI32]
- Add DsValidateSubnetNameA/W stubs.
- Move DsRoleFreeMemory to a better location.

[SDK/INCLUDE]
Add DsValidateSubnetNameA/W prototypes to dsgetdc.h.

svn path=/trunk/; revision=75306
2017-07-08 12:00:44 +00:00
Eric Kohl a18e985b12 [NETAPI32]
- Add DsDeregisterDnsHostRecordsA stub.
- Implement DsDeregisterDnsHostRecordsW.

[SDK/INCLUDE]
Add DsDeregisterDnsHostRecordsA/W prototypes to dsgetdc.h.

svn path=/trunk/; revision=75305
2017-07-08 09:11:22 +00:00
Hermès Bélusca-Maïto 0a7125a8be Integrate the USERINIT changes r75295, r75302 and r75303 from the setup_improvements branch back to trunk.
svn path=/trunk/; revision=75304
2017-07-08 00:23:33 +00:00
Giannis Adamopoulos 201f83b4b1 [SHELL32]
- Simplify SHELL32_CoCreateInitSF by letting the callers fill the PERSIST_FOLDER_TARGET_INFO. This lets us stop using _ILSimpleGetTextW in it which breaks the logic that pidls should be read only by their shell folder. Also add an overload for SHELL32_CoCreateInitSF  that makes it simpler to create a shell folder with a csidl.
- Add a SHELL32_BindToSF helper to share some logic that was duplicated in several shell folders.
- Move SHELL32_GetCustomFolderAttributeFromPath, SHELL32_GetCLSIDForDirectory and SHELL32_GetFSItemAttributes, SHELL32_BindToFS to CFSFolder.cpp as these were fs specific.
- These changes give finer control to shell folders for how the bind will be done and shares more logic that can be shared.

svn path=/trunk/; revision=75301
2017-07-07 20:34:27 +00:00
Eric Kohl 99fe0ae037 [NETAPI32]
- Add DsMergeForestTrustInformationW stub.
- Implement DsGetForestTrustInformationW.

[SDK/INCLUDE]
Add DsGetSiteNameA/W, DsGetForestTrustInformationW and DsMergeForestTrustInformationW prototypes to dsgetdc.h.

svn path=/trunk/; revision=75300
2017-07-07 17:59:14 +00:00
James Tabor 04b696718d [NtGDI]
- Return Set if managed, part of CORE-12888.

svn path=/trunk/; revision=75294
2017-07-06 19:13:49 +00:00
James Tabor a1938e7ca3 [NtUser]
- Part of CORE-13110. Set DC window rectangle and pointer.

svn path=/trunk/; revision=75293
2017-07-06 19:06:29 +00:00
James Tabor b1f132e660 [Gdi32]
- Sync/Port Wine Enhanced/Metafile code. This is a fix for CORE-12888.
- Wine made this difficult to port and keep the whole file unchanged for syncing.

svn path=/trunk/; revision=75292
2017-07-06 18:52:22 +00:00
Giannis Adamopoulos 3b7b8b89b3 [SHELL32] -Remove IShellView_Constructor and CDefView_Constructor. Use SHCreateShellFolderView and SHCreateShellFolderViewEx instead.
svn path=/trunk/; revision=75289
2017-07-05 21:36:20 +00:00
Colin Finck 4c022adf19 [PRINTING]
Apply a consistent style to all similar functions:
- Spoolss functions don't necessarily set ERROR_SUCCESS. Check the boolean return value instead and only query the error code on failure.
- Use AlignRpcPtr and UndoAlignRpcPtr wherever feasible.
- Use one static function per level that can be called from both Get* and Enum* APIs.
- Use PackStrings in all functions that return structures with strings.
- Add TRACEs to all non-static functions in localspl.
- Pass a double pointer to all Marshalling functions and advance to the next structure there.
- Perform sanity checks and return the right error codes in a Windows-compatible way.
- Return TRUE when an Enum* API has no elements to enumerate.

Also fixes CORE-12793

svn path=/trunk/; revision=75287
2017-07-05 15:29:13 +00:00
Pierre Schweitzer f93ac7e964 [RXCE]
- Implement RxFinalizeConnection(), RxOrphanSrvOpens()
- Stub RxOrphanSrvOpensForThisFcb()

[RDBSS]
- Fix a bug in RxCommonDevFCBClose() where prefix table wasn't acquire exclusively; this was problematic due to potential prefix table removal on dereference
- Stub RxCancelNotifyChangeDirectoryRequestsForVNetRoot()

This commit basically allows you to delete a NFS share you would have made use of in ReactOS.
Like net use z: \\share\path can be deleted through net use /delete z:

Note that if you access the share using cmd tools (dir, copy, more, and so on), dismount will work.
If you attempt to access with Explorer, then, handles will be kept open and dismount will fail.

CORE-8204
CORE-11327

svn path=/trunk/; revision=75286
2017-07-05 06:11:10 +00:00
Pierre Schweitzer d135302c2f [MPR]
Import Wine commit:
- 26192671700360859cd8a0133dabcd96ec1a786b, Implement WNetConnectionDialog().

CORE-13516

svn path=/trunk/; revision=75285
2017-07-05 05:40:01 +00:00
Hermès Bélusca-Maïto d876a3ea01 [WELCOME]: UI improvements:
- Allow only one running instance of the Welcome application at a time.
- Implement translating \xhhhh hexadecimal character specifications in topic text descriptions.
- Allow using the keyboard for navigating amongst the topics, and ENTER key presses to run the selected topic command.
  <rant> *OF COURSE*, because we are ReactOS *SO* we are *buggy* (well, user32/win32k), keyboard navigation via arrow keys *DOES NOT WORK*!! (only navigation via TAB key do work) 8^(((( </rant>
  This however works OK on Windows.
- Improve topic buttons activation when mouse hovers around above the window, as well as when window activation is lost or regained.
- Change the default text font to Tahoma.
- Don't hardcode white brush, but instead use stock object WHITE_BRUSH. Similarly, don't hardcode text black colour, but instead use the ambient text colour of the system.
- Add keyboard shortcuts to the default topic items.
- Shift the window ID of both the checkbox and the Exit buttons to be below a fixed topic-button base ID.
- In GetLocaleName(), use more explicit returned-variable names (cchRet, because it's a returned string length in character numbers).

svn path=/trunk/; revision=75282
2017-07-05 02:02:43 +00:00
James Tabor e22e9fc81f [GDI32_WINETEST]
- Sync with Wine main head 2017-07-03.

svn path=/trunk/; revision=75275
2017-07-03 20:39:50 +00:00