ApfelTeeSaft/reactos
1
0
Fork 0
mirror of https://github.com/ApfelTeeSaft/reactos.git synced 2026-09-02 04:13:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

IntRegisterClass did not check for NULL pointer when it alloc memory.

Browse Source 
svn path=/trunk/; revision=20419
This commit is contained in:
Magnus Olsen
2005-12-29 12:40:31 +00:00
parent 677cdc30d5
commit f52b36d570
1 changed files with 22 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
reactos/subsys/win32k/ntuser/class.c
+22 -13
View File
@@ -208,6 +208,27 @@ IntRegisterClass(
Class->hIconSm = lpwcx->hIconSm;
Class->Atom = Atom;
if (MenuName->Length == 0)
{
Class->lpszMenuName.Length =
Class->lpszMenuName.MaximumLength = 0;
Class->lpszMenuName.Buffer = MenuName->Buffer;
}
else
{
Class->lpszMenuName.Length =
Class->lpszMenuName.MaximumLength = MenuName->MaximumLength;
Class->lpszMenuName.Buffer = ExAllocatePoolWithTag(PagedPool, Class->lpszMenuName.MaximumLength, TAG_STRING);
if (Class->lpszMenuName.Buffer == NULL)
{
SetLastWin32Error(ERROR_NOT_ENOUGH_MEMORY);
return(FALSE);
}
RtlCopyUnicodeString(&Class->lpszMenuName, MenuName);
}
if (wpExtra == NULL)
{
if (Flags & REGISTERCLASS_ANSI)
@@ -235,19 +256,7 @@ IntRegisterClass(
}
}
if (MenuName->Length == 0)
{
Class->lpszMenuName.Length =
Class->lpszMenuName.MaximumLength = 0;
Class->lpszMenuName.Buffer = MenuName->Buffer;
}
else
{
Class->lpszMenuName.Length =
Class->lpszMenuName.MaximumLength = MenuName->MaximumLength;
Class->lpszMenuName.Buffer = ExAllocatePoolWithTag(PagedPool, Class->lpszMenuName.MaximumLength, TAG_STRING);
RtlCopyUnicodeString(&Class->lpszMenuName, MenuName);
}
/* Extra class data */
if (Class->cbClsExtra)