ApfelTeeSaft/reactos
1
0
Fork 0
mirror of https://github.com/ApfelTeeSaft/reactos.git synced 2026-08-26 19:33:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Beautification and clarity

Co-authored-by: Victor Perevertkin <[email protected]>
Co-authored-by: Hermès BÉLUSCA - MAÏTO <[email protected]>
This commit is contained in:
Jérôme Gardou
2020-10-20 21:44:54 +02:00
co-authored by Victor Perevertkin Hermès BÉLUSCA - MAÏTO
parent c004b53d77
commit ab825334dd
5 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
base/services/tftpd/CMakeLists.txt
+1 -1
View File
@@ -4,6 +4,6 @@ set_module_type(tftpd win32cui)
add_importlibs(tftpd advapi32 ws2_32 iphlpapi msvcrt kernel32)
add_cd_file(TARGET tftpd DESTINATION reactos/system32 FOR all)
if((NOT MSVC) OR USE_CLANG_CL)
if(GCC OR CLANG)
target_compile_options(tftpd PRIVATE -Wno-format-overflow)
endif()
dll/3rdparty/libxslt/CMakeLists.txt
Vendored
+1 -2
View File
@@ -43,10 +43,9 @@ if(MSVC)
add_importlibs(libxslt ntdll)
endif()
if ((NOT MSVC) OR USE_CLANG_CL)
if(GCC OR CLANG)
target_compile_options(libxslt PRIVATE -Wno-misleading-indentation -Wno-pointer-sign -Wno-unused-function)
endif()
add_pch(libxslt precomp.h SOURCE)
add_cd_file(TARGET libxslt DESTINATION reactos/system32 FOR all)
sdk/lib/crt/msvcrtex.cmake
+3 -3
View File
@@ -96,9 +96,9 @@ add_asm_files(msvcrtex_asm ${MSVCRTEX_ASM_SOURCE})
add_library(msvcrtex ${MSVCRTEX_SOURCE} ${msvcrtex_asm})
target_compile_definitions(msvcrtex PRIVATE _DLL _MSVCRTEX_)
if ((NOT MSVC) OR USE_CLANG_CL)
if(GCC OR CLANG)
target_compile_options(msvcrtex PRIVATE $<$<COMPILE_LANGUAGE:C>:-Wno-main>)
if (LTCG)
if(LTCG)
target_compile_options(msvcrtex PRIVATE -fno-lto)
endif()
endif()
@@ -107,7 +107,7 @@ set_source_files_properties(startup/crtdll.c PROPERTIES COMPILE_DEFINITIONS CRTD
set_source_files_properties(startup/crtexe.c
startup/wcrtexe.c PROPERTIES COMPILE_DEFINITIONS _M_CEE_PURE)
if (NOT MSVC)
if(NOT MSVC)
target_link_libraries(msvcrtex oldnames)
endif()
sdk/lib/drivers/lwip/CMakeLists.txt
+1 -1
View File
@@ -62,6 +62,6 @@ add_library(lwip ${SOURCE})
add_dependencies(lwip bugcodes xdk)
add_pch(lwip precomp.h SOURCE)
if((NOT MSVC) AND LTCG)
if((NOT MSVC) AND LTCG)
target_compile_options(lwip PRIVATE -fno-builtin-malloc -fno-builtin-free)
endif()
sdk/tools/wpp/CMakeLists.txt
+1 -1
View File
@@ -14,7 +14,7 @@ if(MSVC)
# Disable warnings
add_compile_options(
/wd4146 # " unary minus operator applied to unsigned type, result still unsigned"
/wd4146 # "unary minus operator applied to unsigned type, result still unsigned"
/wd4244) # "'=': conversion from 'a' to 'b', possible loss of data"
endif()