ApfelTeeSaft/reactos
1
0
Fork 0
mirror of https://github.com/ApfelTeeSaft/reactos.git synced 2026-09-03 12:23:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

[TELNET]

Browse Source 
Don't attempt to close undefined handles.
Also properly set them on failure as "the contents of the output parameters are indeterminate" on failure.

svn path=/trunk/; revision=58701
This commit is contained in:
Pierre Schweitzer
2013-04-06 23:27:56 +00:00
parent 33a4bc0181
commit 5576d21588
1 changed files with 15 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
reactos/base/applications/network/telnet/src/tnmisc.cpp
+15 -9
View File
@@ -8,9 +8,9 @@ BOOL CreateHiddenConsoleProcess(LPCTSTR szChildName, PROCESS_INFORMATION* ppi,
BOOL fCreated;
STARTUPINFO si;
SECURITY_ATTRIBUTES sa;
HANDLE hInRead;
HANDLE hOutWrite;
HANDLE hErrWrite;
HANDLE hInRead = INVALID_HANDLE_VALUE;
HANDLE hOutWrite = INVALID_HANDLE_VALUE;
HANDLE hErrWrite = INVALID_HANDLE_VALUE;
// Create pipes
// initialize security attributes for handle inheritance (for WinNT)
@@ -19,16 +19,22 @@ BOOL CreateHiddenConsoleProcess(LPCTSTR szChildName, PROCESS_INFORMATION* ppi,
sa.lpSecurityDescriptor = NULL;
// create STDIN pipe
if( !CreatePipe( &hInRead, phInWrite, &sa, 0 ))
if( !CreatePipe( &hInRead, phInWrite, &sa, 0 )) {
hInRead = INVALID_HANDLE_VALUE;
goto error;
}
// create STDOUT pipe
if( !CreatePipe( phOutRead, &hOutWrite, &sa, 0 ))
if( !CreatePipe( phOutRead, &hOutWrite, &sa, 0 )) {
hOutWrite = INVALID_HANDLE_VALUE;
goto error;
}
// create STDERR pipe
if( !CreatePipe( phErrRead, &hErrWrite, &sa, 0 ))
if( !CreatePipe( phErrRead, &hErrWrite, &sa, 0 )) {
hErrWrite = INVALID_HANDLE_VALUE;
goto error;
}
// process startup information
memset( &si, 0, sizeof( si ));
@@ -63,9 +69,9 @@ BOOL CreateHiddenConsoleProcess(LPCTSTR szChildName, PROCESS_INFORMATION* ppi,
return TRUE;
error:
CloseHandle( hInRead );
CloseHandle( hOutWrite );
CloseHandle( hErrWrite );
if (hInRead != INVALID_HANDLE_VALUE) CloseHandle( hInRead );
if (hOutWrite != INVALID_HANDLE_VALUE) CloseHandle( hOutWrite );
if (hErrWrite != INVALID_HANDLE_VALUE) CloseHandle( hErrWrite );
CloseHandle( ppi->hProcess );
CloseHandle( ppi->hThread );