ApfelTeeSaft/reactos
1
0
Fork 0
mirror of https://github.com/ApfelTeeSaft/reactos.git synced 2026-08-26 19:33:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

[FASTFAT][FLTMGR][NTOS] Do not explicitly call ObfDereferenceObject() (#1636)

Browse Source 
"Most code should not directly call the platform-specific ObfDereferenceObject() function but use the ObDereferenceObject() macro instead."

CORE-16081
This commit is contained in:
Bișoc George
2019-06-22 16:20:58 +02:00
committed by Hermès BÉLUSCA - MAÏTO
parent be820b9ca3
commit 42ce8519b6
9 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/filesystems/fastfat/misc.c
+1 -1
View File
@@ -582,7 +582,7 @@ VfatCheckForDismount(
ExDeleteResourceLite(&DeviceExt->FatResource);
/* Dismount our device if possible */
ObfDereferenceObject(DeviceExt->StorageDevice);
ObDereferenceObject(DeviceExt->StorageDevice);
IoDeleteDevice(DeviceExt->VolumeDevice);
}
drivers/filters/fltmgr/Interface.c
+4 -4
View File
@@ -2005,7 +2005,7 @@ FltpDetachFromFileSystemDevice(_In_ PDEVICE_OBJECT DeviceObject)
NextDevice = IoGetLowerDeviceObject(AttachedDevice);
/* Remove the reference we added */
Count = ObfDereferenceObject(AttachedDevice);
Count = ObDereferenceObject(AttachedDevice);
/* Bail if this is the last one */
if (NextDevice == NULL) return Count;
@@ -2028,7 +2028,7 @@ FltpDetachFromFileSystemDevice(_In_ PDEVICE_OBJECT DeviceObject)
IoDeleteDevice(AttachedDevice);
/* Remove the reference we added so the delete can complete */
return ObfDereferenceObject(AttachedDevice);
return ObDereferenceObject(AttachedDevice);
}
DRIVER_FS_NOTIFICATION FltpFsNotification;
@@ -2143,7 +2143,7 @@ DriverEntry(_In_ PDRIVER_OBJECT DriverObject,
if (NT_SUCCESS(Status))
{
FltpFsNotification(RawDeviceObject, TRUE);
ObfDereferenceObject(RawFileObject);
ObDereferenceObject(RawFileObject);
}
RtlInitUnicodeString(&ObjectName, L"\\Device\\RawCdRom");
@@ -2154,7 +2154,7 @@ DriverEntry(_In_ PDRIVER_OBJECT DriverObject,
if (NT_SUCCESS(Status))
{
FltpFsNotification(RawDeviceObject, TRUE);
ObfDereferenceObject(RawFileObject);
ObDereferenceObject(RawFileObject);
}
/* We're done, clear the initializing flag */
drivers/filters/fltmgr/Messaging.c
+5 -5
View File
@@ -369,7 +369,7 @@ NTAPI
FltpClientPortDelete(PVOID Object)
{
PFLT_PORT_OBJECT PortObject = (PFLT_PORT_OBJECT)Object;
ObfDereferenceObject(PortObject->ServerPort);
ObDereferenceObject(PortObject->ServerPort);
}
@@ -447,14 +447,14 @@ Quit:
if (ClientPortObjectType)
{
ObMakeTemporaryObject(ClientPortObjectType);
ObfDereferenceObject(ClientPortObjectType);
ObDereferenceObject(ClientPortObjectType);
ClientPortObjectType = NULL;
}
if (ServerPortObjectType)
{
ObMakeTemporaryObject(ServerPortObjectType);
ObfDereferenceObject(ServerPortObjectType);
ObDereferenceObject(ServerPortObjectType);
ServerPortObjectType = NULL;
}
}
@@ -737,7 +737,7 @@ Quit:
{
if (ClientPortObject)
{
ObfDereferenceObject(ClientPortObject);
ObDereferenceObject(ClientPortObject);
}
if (PortHandle)
@@ -747,7 +747,7 @@ Quit:
else if (ServerPortObject)
{
InterlockedDecrement(&ServerPortObject->NumberOfConnections);
ObfDereferenceObject(ServerPortObject);
ObDereferenceObject(ServerPortObject);
}
if (PortCCB)
ntoskrnl/fsrtl/oplock.c
+1 -1
View File
@@ -454,7 +454,7 @@ FsRtlAcknowledgeOplockBreak(IN PINTERNAL_OPLOCK Oplock,
/* If we dropped oplock, remove our extra ref */
if (Deref)
{
ObfDereferenceObject(Oplock->FileObject);
ObDereferenceObject(Oplock->FileObject);
}
/* And unset FO: no oplock left or shared */
Oplock->FileObject = NULL;
ntoskrnl/io/iomgr/rawfs.c
+1 -1
View File
@@ -148,7 +148,7 @@ RawCheckForDismount(IN PVCB Vcb,
}
/* Dismount our device if possible */
ObfDereferenceObject(Vcb->TargetDeviceObject);
ObDereferenceObject(Vcb->TargetDeviceObject);
IoDeleteDevice((PDEVICE_OBJECT)CONTAINING_RECORD(Vcb,
VOLUME_DEVICE_OBJECT,
Vcb));
ntoskrnl/ob/devicemap.c
+2 -2
View File
@@ -130,7 +130,7 @@ ObSetDeviceMap(IN PEPROCESS Process,
/* Release useless device map if required */
if (NewDeviceMap != NULL)
{
ObfDereferenceObject(DirectoryObject);
ObDereferenceObject(DirectoryObject);
ExFreePoolWithTag(NewDeviceMap, 'mDbO');
}
@@ -235,7 +235,7 @@ ObSetDirectoryDeviceMap(OUT PDEVICE_MAP * DeviceMap,
/* Release useless device map if required */
if (NewDeviceMap != NULL)
{
ObfDereferenceObject(DirectoryObject);
ObDereferenceObject(DirectoryObject);
ExFreePoolWithTag(NewDeviceMap, 'mDbO');
}
ntoskrnl/po/poshtdwn.c
+1 -1
View File
@@ -135,7 +135,7 @@ PopProcessShutDownLists(VOID)
/* Wait for the thread to finish and dereference it */
KeWaitForSingleObject(ShutDownWaitEntry->Thread, 0, 0, 0, 0);
ObfDereferenceObject(ShutDownWaitEntry->Thread);
ObDereferenceObject(ShutDownWaitEntry->Thread);
/* Finally free the entry */
ExFreePoolWithTag(ShutDownWaitEntry, 'LSoP');
ntoskrnl/ps/job.c
+1 -1
View File
@@ -836,7 +836,7 @@ NtSetInformationJobObject (
}
KeLeaveGuardedRegionThread(CurrentThread);
ObfDereferenceObject(Job);
ObDereferenceObject(Job);
return Status;
}
ntoskrnl/wmi/guidobj.c
+1 -1
View File
@@ -247,7 +247,7 @@ WmipOpenGuidObject(
if (!NT_SUCCESS(Status))
{
DPRINT1("ObOpenObjectByPointer failed: 0x%lx\n", Status);
ObfDereferenceObject(GuidObject);
ObDereferenceObject(GuidObject);
GuidObject = NULL;
}