* Add a new Secondary Display Layout option on android that makes the secondary display honor swap button
* add quick menu option for secondary layout
* fix icon
* added other secondary layouts
* Add a new Secondary Display Layout option on android that makes the secondary display honor swap button
# Conflicts:
# src/core/frontend/framebuffer_layout.cpp
* add quick menu option for secondary layout
* fix icon
* added other secondary layouts
* updated secondary menu with functionality to switch external displays
Conflicts:
src/android/app/src/main/java/org/citra/citra_emu/display/SecondaryDisplay.kt
* safety checks for crash prevention
* make secondary menu only appear if a secondary display is available
* update default displayid behavior to exclude "Built"
* update odin 2 bugfix to handle other languages
* Apply clang-format
* Rename "Opposite of Primary Display" option for brevity
* Rename menu_secondary_layout_reverse_primary for consistency
* Rename SecondaryDisplayLayout::ReversePrimary for consistency
* first round of code fixes based on review
* Added android-side enable_secondary_display boolean setting, replacing secondary_display_layout = none on the android side. Exposed it in Layout settings, and secondary display layout is now only selectable if it is enabled. Support for the old option is still in the code, but should no longer be selectable.
Also renamed opposite to reverse_primary in a few other places.
* Update framebuffer layout and renderers to correctly render hybrid mode on both primary and secondary displays
* Apply clang format
* Re-apply terminology changes which were undone by a recent commit
* Removed unused string emulation_secondary_display_default
---------
Co-authored-by: OpenSauce04 <[email protected]>
* EmulationActivity and EmulationFragment clear only their own hooks
* EmulationLifecycleUtil: Rename `remove()` to `removeHook()`
* EmulationLifecycleUtil: Removed unused function `clear()`
* Corrected somewhat incorrect usage of the word "hook"
* Define `onShutdown` and `onPause` hook functions in constructors
* Formatting nitpicks
* Updated license header
* Re-added log messages for attempting to add duplicate hooks
---------
Co-authored-by: OpenSauce04 <[email protected]>
* Enable the SecondScreenPresentation class
* Update everything to enable second screen on android under GL and Vulkan. Still some issues!
* Some attempts to enable surface changes
* OpenGL is working on surface change, vulkan still no
* release surfaces (also fixed vulkan?)
* added and enabled layout setting
* resolve merge conflict
* rearrange switch cases to satisfy linux compiler
* openGL is working!
* several vk changes to try to fix crashes
* maybe vulkan is working?
* removing unnecessary code attempts
* Simplified secondscreen for better performance
* vk_platform.cpp: Fixed build failure caused by bad rebase
* vk_present_window.h: Removed stray newline
* Applied clang-format
* bug fix for odin 2
* Applied clang-format
* Updated license headers
* Moved SecondScreen class to org.citra.citra_emu.display
* Various formatting and readability improvements
* Added brackets where previously absent for readability
* Additional readability improvement
* RendererVulkan::NotifySurfaceChanged: Simplified condition checking
* change all references to "secondary screen" to "secondary display" to limit confusion with top screen / bottom screen
* rename main_window to main_present_window and second_window to secondary_present_window
* Reverted accidentally downgraded compatibility list submodule
* Removed unnecessary log message
* Applied clang-format
* Added a description to the Secondary Display Screen Layout setting
* Added `_ptr` suffix to `secondary_present_window`
This distinguishes it as a pointer, as `main_present_window` isn't a pointer, so there could be confusion on whether to use `.` or `->`
---------
Co-authored-by: OpenSauce04 <[email protected]>
* change dialog without write permissions
* Added update path from lime to azahar on android
* Shows the correct dialog info now
* remove unnecessary comments
* Adjusted `select_which_user_directory_to_use` string to be more readable
* improve the dialog box itself
* tougher fix than originally expected but all works as planned
* remove unnecessary code
* Updated license headers
* MainActivity.kt: Removed stray newline
* PermissionsHandler.kt: Move repeated "LIME3DS_DIRECTORY" string to `LIME3DS_DIRECTORY` constant
* Nitpicky comment adjustments
* Reverted superficial changes to HomeViewModel.kt
* PermissionsHandler.kt: `updateDirectory` --> `attemptAutomaticUpdateDirectory`
+ nitpicky formatting adjustment
* Moved PR additions to PermissionsHandler.kt to new file CitraDirectoryUtils.kt
---------
Co-authored-by: OpenSauce04 <[email protected]>
* Original Portrait Layout
Original Portrait Layout
* type conversion fix for win
* Updated license headers
* Applied clang-format
* android: Reordered Portrait Screen Layout menu
Custom Layout is now at the bottom of the list
---------
Co-authored-by: OpenSauce04 <[email protected]>
* error checking for layout value from older config
* rename enum and update aspect ratio code
* rewrite LargeFrameLayout to support multiple positions
* add settings for smallscreenposition, fix minsize function
* fixed framebuffer from res scale (screenshots)
* add desktop UI for small screen position
* small screen position submenu on desktop
* fix int-float conversion warning
* rename Above and Below to hopefully fix linux issue
* Add Small Screen Position Setting to android settings menu
* fix sliders to work with floats, mostly
* fix android slider textinput ui
* change None enums in settings and cam_params
* Apply clang-format-18
* SettingsAdapter.kt: Make more null pointer exception resistant
* Updated license headers
* Code formatting nitpicks
* fix bug in main.ui that was hiding menu
* replace default layout with a special call to LargeFrame (like SideBySide does)
* fix bug when "large screen" is actually narrower
* edit documentation for LargeScreenLayout
* update PortraitTopFullFrameLayout to use LargeFrameLayout
* fix unary minus on unsigned int bug
* Applied formatting correction
* Added `const`s where appropriate
* android: Add mention of the bottom-right small screen position being the default
* review fixes + more constants
* refactor all Upright calculations to a reverseLayout method, simplifying code and reducing bugs
* Removed stray extra newline
* SettingsAdapter.kt: Fixed some strange indentation
* Removed unnecessary `if` in favour of direct value usage
---------
Co-authored-by: Reg Tiangha <[email protected]>
Co-authored-by: OpenSauce04 <[email protected]>
