Merge pull request #267 from wooferzfg/fix-audit

Fix issues with the Chrome Dev Tools Audit
This commit is contained in:
Christopher Serr
2020-02-22 19:22:03 +01:00
committed by GitHub
6 changed files with 32 additions and 10 deletions
+1
View File
@@ -5,6 +5,7 @@
@font-face {
font-family: 'Font Awesome 5 Free';
font-display: swap;
font-style: normal;
font-weight: 900;
font-display: auto;
+2
View File
@@ -4,11 +4,13 @@
@font-face {
font-family: timer;
font-display: swap;
src: url(timer.woff);
}
@font-face {
font-family: fira;
font-display: swap;
src: url(FiraSans-Regular.woff);
}
+3 -2
View File
@@ -1,9 +1,10 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no">
<meta name="description" content="A version of LiveSplit that works on a lot of platforms.">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=5.0">
<title>LiveSplit One</title>
</head>
+10 -1
View File
@@ -97,7 +97,12 @@ export class LayoutEditor extends React.Component<Props, State> {
<div className="layout-editor-inner">
<div className="btn-group">
<ContextMenuTrigger id="add-button-context-menu" ref={(c) => contextTrigger = c}>
<button onClick={toggleMenu}><i className="fa fa-plus" aria-hidden="true"></i></button>
<button
aria-label="Add Component"
onClick={toggleMenu}
>
<i className="fa fa-plus" aria-hidden="true"></i>
</button>
</ContextMenuTrigger>
<ContextMenu id="add-button-context-menu">
<MenuItem onClick={(_) => this.addComponent(LiveSplit.CurrentComparisonComponent)}>
@@ -154,23 +159,27 @@ export class LayoutEditor extends React.Component<Props, State> {
</MenuItem>
</ContextMenu>
<button
aria-label="Remove Component"
onClick={(_) => this.removeComponent()}
className={this.state.editor.buttons.can_remove ? "" : "disabled"}
>
<i className="fa fa-minus" aria-hidden="true"></i>
</button>
<button
aria-label="Duplicate Component"
onClick={(_) => this.duplicateComponent()}
>
<i className="fa fa-clone" aria-hidden="true"></i>
</button>
<button
aria-label="Move Component Up"
onClick={(_) => this.moveComponentUp()}
className={this.state.editor.buttons.can_move_up ? "" : "disabled"}
>
<i className="fa fa-arrow-up" aria-hidden="true"></i>
</button>
<button
aria-label="Move Component Down"
onClick={(_) => this.moveComponentDown()}
className={this.state.editor.buttons.can_move_down ? "" : "disabled"}
>
+5 -4
View File
@@ -217,17 +217,17 @@ export class LiveSplit extends React.Component<{}, State> {
</div>
<div className="buttons" style={{ width: this.state.layoutWidth }}>
<div className="small">
<button onClick={(_) => this.undoSplit()}>
<button aria-label="Undo Split" onClick={(_) => this.undoSplit()}>
<i className="fa fa-arrow-up" aria-hidden="true" /></button>
<button onClick={(_) => this.togglePauseOrStart()}>
<button aria-label="Pause" onClick={(_) => this.togglePauseOrStart()}>
<i className="fa fa-pause" aria-hidden="true" />
</button>
</div>
<div className="small">
<button onClick={(_) => this.skipSplit()}>
<button aria-label="Skip Split" onClick={(_) => this.skipSplit()}>
<i className="fa fa-arrow-down" aria-hidden="true" />
</button>
<button onClick={(_) => this.reset()}>
<button aria-label="Reset" onClick={(_) => this.reset()}>
<i className="fa fa-times" aria-hidden="true" />
</button>
</div>
@@ -275,6 +275,7 @@ export class LiveSplit extends React.Component<{}, State> {
!this.state.isDesktop &&
!this.state.sidebarOpen &&
<button
aria-label="Open Sidebar"
className="sidebar-button fa fa-bars"
onClick={((e: boolean) => this.onSetSidebarOpen(e)) as any}
/>
+11 -3
View File
@@ -201,7 +201,9 @@ export class SideBarContent extends React.Component<Props, State> {
return (
<div className="sidebar-buttons">
<div className="livesplit-title">
<span className="livesplit-icon"><img src={LiveSplitIcon} /></span>
<span className="livesplit-icon">
<img src={LiveSplitIcon} alt="LiveSplit Logo" />
</span>
<h2> LiveSplit One</h2>
</div>
<hr />
@@ -214,11 +216,17 @@ export class SideBarContent extends React.Component<Props, State> {
<hr />
<h2>Compare Against</h2>
<div className="choose-comparison">
<button onClick={(_) => this.props.callbacks.switchToPreviousComparison()}>
<button
aria-label="Switch to Previous Comparison"
onClick={(_) => this.props.callbacks.switchToPreviousComparison()}
>
<i className="fa fa-caret-left" aria-hidden="true" />
</button>
<span>{this.state.comparison}</span>
<button onClick={(_) => this.props.callbacks.switchToNextComparison()}>
<button
aria-label="Switch to Next Comparison"
onClick={(_) => this.props.callbacks.switchToNextComparison()}
>
<i className="fa fa-caret-right" aria-hidden="true" />
</button>
</div>