reactos

mirror of https://github.com/ApfelTeeSaft/reactos.git synced 2026-08-30 04:13:33 +00:00

Files

T

Sir Richard 83a2328786 [NTOS]: Blimey this was a hard one. When using the reserved flag to request 1MB in a new process (which is used for starting SMSS and CSRSS), we must request 1MB - 256 bytes (or any number, actually) to offset the fact that with a base address of 0x4, a 1MB region gets us at 0x100FFF, and not 0xFFFF, because Windows computes ending address *before* alignment, and then returns a new region size for you (so if you pass in 1MB, you get 1MB + 4096KB). In Win32csr, when the code is trying to release 1MB, this ended up in our "Case A", because it would still leave a page in the VAD. Fixed rtl to request just shy off a MB. Verified on Windows as well.

[NTOS]: The fix above was due to fixing "EndingAddress" which was being initialized to zero too late (after writing to it!). This caused allocations with a fixed base address that were already on top of another allocation not to be seen as a conflict, then we tried inserting a VAD and received an ASSERT saying we've already found a VAD there. After fixing the sizing code, the bug above creeped up.
Whoever wrote the NtFreeVirtualMemory test is a godsend. It has been nailing bug after bug in the VAD implementation. Thank you.

svn path=/trunk/; revision=55990

2012-03-04 06:42:49 +00:00

amd64

{RTL]

2012-02-09 11:54:59 +00:00

arm

Create a branch for header work.

2010-02-26 22:57:55 +00:00

i386

[ASM]

2011-10-13 15:16:29 +00:00

powerpc

Create a branch for header work.

2010-02-26 22:57:55 +00:00

access.c

Create a branch for header work.

2010-02-26 22:57:55 +00:00

acl.c

[RTL]

2011-09-20 17:33:51 +00:00

actctx.c

[ACTCTX]

2011-12-09 16:47:50 +00:00

assert.c

Create a branch for header work.

2010-02-26 22:57:55 +00:00

atom.c

[RTL]

2012-02-10 17:36:11 +00:00

avlsupp.c

[RTL]: Sorry, forgot this critical part of the VAD commit.

2012-03-04 00:47:20 +00:00

avltable.c

[RTL/AVL]

2011-02-21 13:33:13 +00:00

bitmap.c

[RTL]

2012-02-13 14:35:26 +00:00

bootdata.c

[NDK/RTL]: Fix RtlGetSetBootStatusData prototype and add the BSD Items that can be set with it.

2012-01-31 02:33:02 +00:00

byteswap.c

[RTL]

2011-10-12 21:11:02 +00:00

CMakeLists.txt

[RTL]

2011-10-13 21:48:10 +00:00

compress.c

Create a branch for header work.

2010-02-26 22:57:55 +00:00

condvar.c

Create a branch for header work.

2010-02-26 22:57:55 +00:00

crc32.c

[RTL]

2010-09-25 21:20:54 +00:00

critical.c

[RTL]

2012-02-04 13:47:16 +00:00

dbgbuffer.c

[RTL]

2011-12-16 20:12:28 +00:00

debug.c

[RTL]

2011-09-20 17:33:51 +00:00

dos8dot3.c

[RTL]

2011-09-20 17:33:51 +00:00

encode.c

Create a branch for header work.

2010-02-26 22:57:55 +00:00

env.c

[RTL]

2011-09-20 17:33:51 +00:00

error.c

[NTDLL/RTL]: Implement RtlGet/SetThreadErrorMode.

2012-02-20 01:13:31 +00:00

exception.c

[NDK/RTL]: Implement, define, fix, and comment RtlSetUnhandledExceptionFilter.

2011-12-18 01:50:11 +00:00

generictable.c

[RTL]

2011-08-01 03:23:53 +00:00

handle.c

[RTL]

2011-12-17 08:30:48 +00:00

heap.c

[RTL]

2011-12-24 22:45:26 +00:00

heap.h

[RTL]

2012-02-04 18:35:56 +00:00

heapdbg.c

[RTL]

2011-12-17 08:22:04 +00:00

heappage.c

[RTL]

2011-11-11 11:55:49 +00:00

image.c

[RTL]

2011-11-20 19:45:06 +00:00

interlck.c

Create a branch for header work.

2010-02-26 22:57:55 +00:00

largeint.c

[RTL]

2011-08-19 21:14:11 +00:00

luid.c

Create a branch for header work.

2010-02-26 22:57:55 +00:00

mem.c

[RTL]

2011-08-19 18:39:47 +00:00

message.c

- There's no such thing as PRTL_MESSAGE_RESOURCE_ENTRY, use PMESSAGE_RESOURCE_ENTRY instead.

2010-06-27 19:56:57 +00:00

network.c

[RTL]: Force RtlIpToString APIs to behave inexplicably like on Windows, returning -1 instead of crashing when sprintfing to a NULL pointer.

2012-02-20 06:37:13 +00:00

nls.c

Fix build

2012-01-24 21:56:02 +00:00

path.c

[RTL]

2012-02-22 12:02:59 +00:00

ppb.c

[RTL]

2011-09-19 11:09:09 +00:00

process.c

[NTOS]: Blimey this was a hard one. When using the reserved flag to request 1MB in a new process (which is used for starting SMSS and CSRSS), we must request 1MB - 256 bytes (or any number, actually) to offset the fact that with a base address of 0x4, a 1MB region gets us at 0x100FFF, and not 0xFFFF, because Windows computes ending address *before* alignment, and then returns a new region size for you (so if you pass in 1MB, you get 1MB + 4096KB). In Win32csr, when the code is trying to release 1MB, this ended up in our "Case A", because it would still leave a page in the VAD. Fixed rtl to request just shy off a MB. Verified on Windows as well.

2012-03-04 06:42:49 +00:00

propvar.c

Create a branch for header work.

2010-02-26 22:57:55 +00:00

random.c

Create a branch for header work.

2010-02-26 22:57:55 +00:00

rangelist.c

[RTL]

2012-02-25 15:20:32 +00:00

readme.txt

Create a branch for header work.

2010-02-26 22:57:55 +00:00

registry.c

[RTL]

2011-10-08 13:50:14 +00:00

res.c

[RTL]

2012-02-10 17:36:11 +00:00

resource.c

Create a branch for header work.

2010-02-26 22:57:55 +00:00

rtl.h

* Include NDK headers on-demand.

2011-08-17 14:04:33 +00:00

rtlavl.h

[NTOS]: Implement an AVL node deletion algorithm (RtlpDeleteAvlTreeNode). Use it in MiRemoveNode, now implemeneted, and RtlDeleteElementGenericTableAvl, also now implemented. It hopefully works.

2010-07-24 04:00:22 +00:00

rtlp.h

[RTL]

2011-09-19 19:31:21 +00:00

sd.c

{RTL]

2012-02-09 11:54:59 +00:00

security.c

Create a branch for header work.

2010-02-26 22:57:55 +00:00

sid.c

[RTL]

2011-09-20 17:33:51 +00:00

slist.c

[RTL]

2012-02-10 17:36:11 +00:00

splaytree.c

[RTL]

2011-08-01 03:23:53 +00:00

srw.c

[RTL]

2011-09-19 19:31:21 +00:00

thread.c

[RTL]: Document, define, implement, and export RtlSetThreadIsCritical.

2012-01-30 01:14:33 +00:00

time.c

[RTL]

2012-02-10 17:36:11 +00:00

timerqueue.c

[RTL/NTDLL/KERNEL32]: Rtl provides worker queue and timer queue functionality, which queues a worker thread associated with a caller-supplied callback. In Windows, Rtl by default calls RtlCreateUserThread, but as soon as kernel32 loads, it's DllMain calls an exported function RtlSetThreadPoolStartFunc which changes that default to a special Base function that calls CreateRemoteThread instead. The net result is that Win32 processes using the Rtl functionality get their threads properly registered with CSRSS. In ReactOS, this did not happen, so when those threads called into CSRSS, CSRSS had no CSR_THREAD structure/state for them, which is why CsrCreateThread (and the API loop) are so badly hacked. This commit implements RtlSetThreadPoolStartFunc, implements the kernel32 base functions which wrap CreateRemoteThread, and implements the rtl functions which wrap RtlCreateUserThread. Services, Setup, and any ReactOS application using RPC now have the worker threads correctly registered.

2012-02-19 10:06:31 +00:00

timezone.c

[RTL]

2011-09-19 19:31:21 +00:00

unicode.c

[RTL]

2012-02-16 14:37:53 +00:00

unicodeprefix.c

Create a branch for header work.

2010-02-26 22:57:55 +00:00

vectoreh.c

[RTL]

2011-02-10 11:47:17 +00:00

version.c

Create a branch for header work.

2010-02-26 22:57:55 +00:00

wait.c

[RTL]

2011-02-10 11:47:17 +00:00

workitem.c

2012-02-19 10:06:31 +00:00

readme.txt

RTL restrictions:

ExAllocatePool (and friends) must be used exclusively. RtlAllocateHeap (and friends) must NOT be used! ExAllocatePool (and friends) translate to RtlAllocateHeap (and friends) in ntdll\rtl\libsupp.c.

RtlEnterCriticalSection (and friends) must be used exclusively. ExAcquireFastMutex (and friends) must NOT be used! RtlEnterCriticalSection (and friends) translate to ExAcquireFastMutex (and friends) in ntoskrnl\rtl\libsupp.c. This means that RtlEnterCriticalSection (and friends) can NOT be used recursively in RTL. The reason for choosing RtlEnterCriticalSection (and friends) over ExAcquireFastMutex (and friends) is that the FAST_MUTEX struct is smaller than the RTL_CRITICAL_SECTION struct.