Joachim Henze 222acf5a3e [NTUSER] Scrollbar.c, Avoid potential out-of-bounds-accesses in co_IntSetScrollInfo() CORE-17777 ...

This is an addendum to
0.4.15-dev-3174-g dda9c3979e CORE-17769 and
0.4.15-dev-3147-g 3bf7e3ac13 CORE-17754 CORE-17755

We have not seen this happening in real-life yet, but some code-fragments within co_IntSetScrollInfo()
e.g. line 628 if (nBar == SB_CTL) do clearly indicate that nBar can be 2 (SB_CTL).
Some lines below we definitely must not access those 4 static arrays out of bounds then via nBar as access index!

Ftr with a bit of grepping I also found some calls like NtUserSetScrollInfo(Wnd, SB_CTL, &Info, FALSE);
e.g: in win32ss/user/user32/controls/scrollbar.c so I am pretty sure nBar == 2 can happen in practice within co_IntSetScrollInfo().

I question whether any of those reads/writes to those static arrays (or the comparisons) would make any sense on index 2,
so we should aim to eliminate them altogether in the future.

2021-09-20 03:05:05 +02:00

..

misc

[WIN32K] Fix 64 bit issues (#420)

2018-03-18 15:53:52 +01:00

accelerator.c

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

2017-10-03 07:45:34 +00:00

accelerator.h

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

2017-10-03 07:45:34 +00:00

callback.c

[WIN32K:NTUSER] Zero allocated memory in IntCbAllocateMemory.

2020-06-24 09:15:27 +02:00

callback.h

[NTUser] Fix Strings and Format to Hooks

2020-04-03 03:58:29 -05:00

callproc.c

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

2017-10-03 07:45:34 +00:00

caret.c

[NTUSER] Fix caret display mistake (#2180)

2019-12-26 19:08:01 +09:00

caret.h

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

2017-10-03 07:45:34 +00:00

class.c

[WIN32K] Allocate a buffer for a classname that is too long

2020-04-27 12:54:10 +02:00

class.h

[WIN32SS][USER32] Add Ghost codes (retrial of #1100) (#1112)

2018-12-11 12:30:59 +09:00

clipboard.c

[WIN32SS] Trim EOL white-space

2020-12-19 17:51:37 +01:00

clipboard.h

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

2017-10-03 07:45:34 +00:00

console.c

[FORMATTING] Remove trailing whitespace. Addendum to 34593d93.

2021-09-13 03:52:22 +02:00

csr.c

[FORMATTING] Remove trailing whitespace. Addendum to 34593d93.

2021-09-13 03:52:22 +02:00

csr.h

[FORMATTING] Remove trailing whitespace. Addendum to 34593d93.

2021-09-13 03:52:22 +02:00

cursoricon.c

[REACTOS] Improve/Fix some "printf" formats (#555)

2018-05-30 14:18:23 +02:00

cursoricon.h

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

2017-10-03 07:45:34 +00:00

dce.h

[REACTOS] Addendum to 5c7ce4475e - Fix MSVC 2015 build

2021-05-12 11:04:29 +02:00

dde.c

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

2017-10-03 07:45:34 +00:00

defwnd.c

[User32] Return Default Window Procedure for WM_DEVICECHANGE

2020-04-11 17:58:38 -05:00

desktop.c

[WIN32K:NTUSER] Make sure to hold User Global Lock before unmapping desktop heap

2021-08-03 23:13:19 +02:00

desktop.h

[WIN32K:NTUSER] Assert global user lock is held exclusively when using global & desktop heaps

2021-08-03 23:13:19 +02:00

display.c

[WIN32K] Check if a graphics device already exists before trying to add it

2021-07-15 08:32:46 +02:00

draw.c

[Win32SS] Fix Mask for Draw Frame States

2020-04-05 21:11:44 -05:00

event.c

[WIN32SS][NTUSER] Fix message time (#1259)

2019-04-12 07:56:04 +09:00

focus.c

[NTUSER] Fix ShellHook notifications when creating/activating windows (#2396)

2020-03-05 15:39:23 +01:00

focus.h

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

2017-10-03 07:45:34 +00:00

ghost.c

[WIN32SS:USER] Some minimal work and fixes concerning message queues timeouts.

2019-12-29 16:14:15 +01:00

ghost.h

[NTUSER] Implement creating the system threads

2018-12-19 16:13:18 +02:00

guicheck.c

[FORMATTING] Remove trailing whitespace. Addendum to 34593d93.

2021-09-13 03:52:22 +02:00

guicheck.h

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

2017-10-03 07:45:34 +00:00

hook.c

[WIN32K] Use KeStackAttachProcess

2019-06-15 21:26:41 +02:00

hook.h

[WIN32K] Fix 64 bit issues (#420)

2018-03-18 15:53:52 +01:00

hotkey.c

[WIN32SS:NTUSER] Implement "Window Snap" feature (#1226)

2019-01-15 14:36:41 +01:00

hotkey.h

[WIN32SS:NTUSER] Implement "Window Snap" feature (#1226)

2019-01-15 14:36:41 +01:00

ime.c

[IMM32] ImmGenerateMessage and ImmTranslateMessage (#3914)

2021-08-18 08:42:12 +09:00

input.c

[REACTOS] Cleanup INIT and some PAGE section allocations

2020-11-02 21:45:31 +03:00

input.h

[REACTOS] Addendum to 5c7ce4475e - Fix MSVC 2015 build

2021-05-12 11:04:29 +02:00

kbdlayout.c

[WIN32SS] Disable by default the dumping function. Addendum to 69f90508.

2021-09-19 00:46:56 +02:00

keyboard.c

[WIN32K] Fix uninitialized variable

2021-07-27 14:44:14 +02:00

layered.c

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

2017-10-03 07:45:34 +00:00

main.c

[WIN32K] Do not release twice the lock on error path

2021-08-06 15:18:21 +02:00

menu.c

[WIN32K:menu] Use signed types for negative values...

2019-10-12 16:19:58 +02:00

menu.h

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

2017-10-03 07:45:34 +00:00

message.c

[NTUSER] Demote ERR to TRACE, also some minor corrections (#3132)

2020-09-05 17:59:10 +03:00

metric.c

[IMM32] ImmCreateContext, ImmDestroyContext, DllMain etc. (#3867)

2021-08-04 09:41:59 +09:00

misc.c

[IMM32] Add some candidate handlings (#3799)

2021-07-11 09:48:15 +09:00

mmcopy.h

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

2017-10-03 07:45:34 +00:00

monitor.c

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

2017-10-03 07:45:34 +00:00

monitor.h

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

2017-10-03 07:45:34 +00:00

mouse.c

[NTUSER] Support MK_SHIFT/MK_CONTROL of mouse messages (#2038)

2019-11-16 09:49:49 +09:00

msgqueue.c

[REACTOS] Cleanup INIT and some PAGE section allocations

2020-11-02 21:45:31 +03:00

msgqueue.h

[REACTOS] Addendum to 5c7ce4475e - Fix MSVC 2015 build

2021-05-12 11:04:29 +02:00

nonclient.c

[WIN32K:NTUSER] NC_IconForWindow(): Remove redundant if() (#2842)

2020-05-26 20:25:39 +02:00

ntstubs.c

[IMM32] Rewrite ImmAssociateContextEx (#3961)

2021-09-16 19:29:49 +09:00

ntuser.c

[WIN32K] Init User part after GDI one.

2021-08-06 10:15:02 +02:00

ntuser.h

[WIN32K] Init User part after GDI one.

2021-08-06 10:15:02 +02:00

object.c

[WIN32K] Fix 64 bit issues (#420)

2018-03-18 15:53:52 +01:00

object.h

[XDK] Remove UNREFERENCE_LOCAL_VARIABLE macro

2021-01-19 00:15:02 +03:00

painting.c

[WIN32K:USER] Fix potential use after free when painting child windows

2021-08-03 23:13:19 +02:00

painting.h

[NtGDI] Update Region code

2019-04-17 14:43:24 -05:00

prop.c

[NTUSER] Fix stack memory disclosure in NtUserBuildPropList (#3023)

2020-08-08 14:05:22 +09:00

prop.h

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

2017-10-03 07:45:34 +00:00

scroll.h

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

2017-10-03 07:45:34 +00:00

scrollbar.c

[NTUSER] Scrollbar.c, Avoid potential out-of-bounds-accesses in co_IntSetScrollInfo() CORE-17777

2021-09-20 03:05:05 +02:00

scrollex.c

[WIN32SS][NTUSER] Fix ScrollWindowEx SW_SCROLLCHILDREN (#2327)

2020-02-11 20:59:14 +09:00

session.c

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

2017-10-03 07:45:34 +00:00

shutdown.c

[WIN32K:NTUSER] Add an extra optional "Process" parameter to the GetProcessLuid() function to be used alternatively in place of "Thread" to retrieve the LUID.

2018-08-19 22:18:30 +02:00

shutdown.h

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

2017-10-03 07:45:34 +00:00

simplecall.c

[WIN32K:NTUSER] Allocate & free timers under global user lock

2021-08-03 23:13:19 +02:00

sysparams.c

[FORMATTING] Remove trailing whitespace. Addendum to 34593d93.

2021-09-13 03:52:22 +02:00

sysparams.h

[WIN32K][DESK.CPL]: Add fit and fill background placement options (#28)

2017-10-13 21:44:02 +02:00

tags.h

[NTOS][CLASS2][FFS][WIN32SS] Fix some pool tags so that they correctly appear in pool dump lists.

2019-11-01 19:12:27 +01:00

timer.c

[WIN32K:NTUSER] Allocate & free timers under global user lock

2021-08-03 23:13:19 +02:00

timer.h

[REACTOS] Addendum to 5c7ce4475e - Fix MSVC 2015 build

2021-05-12 11:04:29 +02:00

useratom.c

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

2017-10-03 07:45:34 +00:00

useratom.h

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

2017-10-03 07:45:34 +00:00

userfuncs.h

[WIN32K:NTUSER] Similarly to what was done in USERSRV for harderrors, introduce the _scwprintf() helper function based on the imported _vscwprintf().

2018-08-19 22:18:34 +02:00

usrheap.c

[WIN32K:NTUSER] In debug builds, enable free & tail checking when creating heaps

2021-08-03 23:13:19 +02:00

usrheap.h

[WIN32K:NTUSER] Assert global user lock is held exclusively when using global & desktop heaps

2021-08-03 23:13:19 +02:00

vis.c

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

2017-10-03 07:45:34 +00:00

vis.h

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

2017-10-03 07:45:34 +00:00

win32.h

[NTUSER] Improve NtUserQueryWindow (#3915)

2021-08-21 07:31:10 +09:00

win32kdebug.h

[CMAKE] Zap builddir.h.cmake and instead define macros globally

2018-06-30 13:26:56 +02:00

windc.c

[REACTOS] Cleanup INIT and some PAGE section allocations

2020-11-02 21:45:31 +03:00

window.c

[NTUSER] Improve NtUserQueryWindow (#3915)

2021-08-21 07:31:10 +09:00

window.h

[Win32SS] Support Module Versioning.

2019-09-24 17:40:18 -05:00

winpos.c

[WIN32SS][NTUSER] ShowWindow.SW_MINIMIZE should show window (#3700)

2021-06-01 11:11:23 +09:00

winpos.h

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

2017-10-03 07:45:34 +00:00

winsta.c

[WIN32K] HACK: create a DC on all display devices and display wallpaper

2021-07-10 16:27:44 +02:00

winsta.h

[REACTOS] Addendum to 5c7ce4475e - Fix MSVC 2015 build

2021-05-12 11:04:29 +02:00