mirror of
https://github.com/ApfelTeeSaft/reactos.git
synced 2026-08-26 19:33:31 +00:00
Hermès Bélusca-Maïto
d6f4c0887a
Addendum to commit7b081be46d(PR #7158). CORE-15156, CORE-19691, CORE-19692 Since commit7b081be46d(PR #7158), one can create shell links that point to a file in a subdirectory of SystemRoot (e.g. X:\reactos) or SystemRoot\system32 using a shell "special shell folder" syntax, for example: `shell:windows\Readme.txt` (--> X:\reactos\Readme.txt) , `shell:windows\system32\cmd.exe` , or: `shell:system\cmd.exe` (--> X:\reactos\system32\cmd.exe) . An `EXP_SPECIAL_FOLDER` data block allows parts of a shortcuts pidl to be overridden by such a special folder. - In these cases, try to build the shortcut pidl such that it faithfully mirrors the intended path. For example, when using `shell:system\cmd.exe`, resolve the `shell:system` part to `X:\reactos\system32` instead of just `X:\reactos` ; this helps understanding what happens when spelunking into such a shell link. This also helps when converting such a path to one containing unexpanded environment variables, for the purposes of making the Windows explorer shell show the correct shortcut target path, or resolve it independently of the SystemRoot being used; and, to be able to use the path for the shortcut icon. - Get rid of the `index`/`specialindex` variables. These were used for making the `EXP_SPECIAL_FOLDER` data block point to the correct path suffix part that follows the special path prefix in the ID list. Hardcoding its value caused problems when the special path prefix is made to contain more path elements than just "X:\reactos". For example, "X:\reactos\system32" in the case of the `shell:system` prefix. Instead, retrieve the length of the special path prefix, then, compare it with the length of the path elements being parsed in the loop. ---- This problem was made explicit when the the following code path is run: ``` shell32!CShellLink.cpp:CShellLink::Load(IStream *stm) --> ILCombine(folder, m_pPidl + pSpecial->cbOffset) ```