Commit Graph
6315 Commits
Author SHA1 Message Date
Stanislav Motylkov af405b51ce [SHLWAPI] Update Russian (ru-RU) translation
Addendum to 0533a67b18. CORE-19278
2026-06-20 13:12:28 +03:00
Katayama Hirofumi MZ 0533a67b18 [SHLWAPI][SHELL32][SDK] Support SHRestrictedMessageBox (#9160)
Implementing missing features...
JIRA issue: CORE-19278
- Add IDS_RESTRICTED and IDS_RESTRICTIONS
  resource strings.
- Implement SHRestrictedMessageBox function.
- Modify shlwapi.spec.
- Add prototype into <shlwapi_undoc.h>.
- Restrict Folder Options on
  REST_NOFOLDEROPTIONS by using
  SHRestrictedMessageBox.
2026-06-20 09:25:47 +09:00
Amine Khaldi c51c284474 [VBSCRIPT] Sync with Wine 10.0. CORE-20606 2026-06-19 19:33:57 +01:00
Eric Kohl d087f8d58b [IFMON] Rename some resource IDs 2026-06-19 19:24:56 +02:00
Eric Kohl a3d4ae2794 [IFMON] Implement the 'delete arpcache' command in the 'interface ip' context 2026-06-19 18:45:22 +02:00
Mohammad Amin Mollazadeh b4b8774bee [SETUPAPI] Fix SetupGetBinaryField not reading HEX values properly from INF files (#9182)
CORE-20657, CORE-13525

Fix an issue in `SetupGetBinaryField()` that made the GUI installer unable to read INF files properly.
For this reason, all the binary values in the registry on a fresh ReactOS installation were all set to `0x00`.

The reason was that the custom HEX parser in Wine's `SetupGetBinaryField()` is broken.
As a solution, we can replace it with a call to C's standard `wcstoul()` function.

(Note that Wine fixed this problem in wine-11, still with a hand-made hex-value parser...)
2026-06-19 17:16:19 +02:00
Eric Kohl ab2393c0de [IFMON] Implement the 'add dns' command in the 'interface ip' context
The index argument is not supported yet.
2026-06-19 10:37:50 +02:00
Timo Kreuzer aaf231f00f [SHELL32] Forward SHGetInstanceExplorer to shcore.GetProcessReference
Fixes 3 shcore wine tests.
2026-06-18 23:27:41 +00:00
Timo Kreuzer 5a4ed508fd [SHLWAPI] Move all remaining kernelbase functions to kernelbase.c
This way the other files are almost completely identical to Wine-10 and once we export those functions from kernelbase, we can delete them from there.
2026-06-18 23:27:41 +00:00
Timo Kreuzer 6adc874cbb [SHLWAPI] Use kernelbase
This replaces implementations that no longer exist in Wine-10.0's shlwapi
Also forward some exports to kernelbase_ros. This is to prevent them from being reimported from shell32, which forwards them here.
It is not exactly what Windows does (which exports the import stubs), but it should be good enough for now.
2026-06-18 23:27:41 +00:00
Timo Kreuzer 6a8c5c999c [KERNELBASE] Fix some string functions to pass tests 2026-06-18 23:27:41 +00:00
Timo Kreuzer 325b7adcd9 [SHLWAPI] Move some functions to shlwapi_main.c
This moves WhichPlatform, SHIsLowMemoryMachine and SHGetViewStatePropertyBag to shlwapi_main.c, where they are in Wine-10.0
2026-06-18 23:27:41 +00:00
Timo Kreuzer 8bd4911054 [SHLWAPI] Update WhichPlatform from Wine-10.0 2026-06-18 23:27:41 +00:00
Timo Kreuzer 88337f5e7a [SHLWAPI] Reformat WhichPlatform (no code changes) 2026-06-18 23:27:41 +00:00
Timo Kreuzer afcac332cf [SHLWAPI] Remove unneeded changes
This reverts part of d663eb4466
2026-06-18 23:27:41 +00:00
Timo Kreuzer 0f9e90134d [SHLWAPI] Adjust spec file to use auto-ordinals
All fixed ordinals are at the top, automatic ones below.
This matches what Wine does.
Add missing NT6+ PathCreateFromUrlAlloc
2026-06-18 23:27:41 +00:00
Timo Kreuzer 2dd8a784c7 [SHLWAPI] Forward some functions to shcore.dll
Some have a forwarder in the spec file, some will export the import-stub. This is how Wine has it.
2026-06-18 23:27:41 +00:00
Timo Kreuzer d829baa006 [SHLWAPI] Use malloc/free instead of HeapAlloc/HeapFree
This is what wine does. To avoid a dependency on msvcrt, link crtheap library, that provides simple wrappers around HeapAlloc, etc.
2026-06-18 23:27:41 +00:00
Timo Kreuzer 4d8ce043c4 [SHLWAPI] Add StrFormatByteSizeEx from Wine-10.0 2026-06-18 23:27:41 +00:00
Timo Kreuzer aac9cd589d [SHLWAPI] Reduce diff to wine-10.0 2026-06-18 23:27:41 +00:00
Timo Kreuzer 0c2acefd64 [SHLWAPI] Switch Vista checks from preprocessor to dynamic
Check the OS version in the PEB to decide how to handle certain nthings.
This allows to keep NT5 backwards compatibility, even if the the code is compiled for Vista, which is needed for Wine code.
2026-06-18 23:27:41 +00:00
Timo Kreuzer 403da61347 [SHCORE] Apply some fixes that we have in shlwapi 2026-06-18 23:27:41 +00:00
Timo Kreuzer 628ce75acd [SHCORE] Import from Wine-10.0 2026-06-18 23:27:41 +00:00
Eric Kohl c1670e1614 [IFMON] Remove an unused variable. 2026-06-18 18:22:11 +02:00
Eric Kohl 59adcd8a8a [IFMON] Add the 'add address' command to the 'interface ip' context
And fix the output of the dump command.
2026-06-18 17:57:20 +02:00
Eric Kohl ace5f8bde9 [NETSH][IFMON] PrintMessageFromModule must use ConResMsgPrintfExV to print messages
- Update the format strings in ifmon.dll.
2026-06-17 16:15:14 +02:00
Eric Kohl 07ce53e846 [IFMON] Implement the 'set dns' command
- Replace some magic values.
- Improve some parameter checks in the 'set address' command.
2026-06-17 11:29:08 +02:00
Mohammad Amin MollazadehandMaotong Zhang ea313e6129 [MSI] Fix not showing combobox items (#9165)
Import fix from Wine-11.6, commit https://github.com/wine-mirror/wine/commit/46e5cabca7be1d09d561f6203f073a7bff385d5d

msi: Add ComboBox items, using value if text does not exist.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56296

PR #8971 will upgrade module to Wine-10.0,
so guard the change with `#ifdef __REACTOS__`. Fixes CORE-15709.

Co-authored-by: Maotong Zhang <[email protected]>
2026-06-16 17:52:31 +03:00
Mohammad Amin Mollazadeh 91146de1cd [KERNEL32] BasepCopyFileExW: Check dwCopyFlags properly (#9133)
The function didn't check if `COPY_FILE_FAIL_IF_EXISTS` bit flag is set
or not, always failing if _any_ flags were set and the destination file
already existed.

This behavior was probably implemented under assumption that
`COPY_FILE_FAIL_IF_EXISTS` is the only valid flag, but it's not the case.
There are other flags, so this was breaking applications when they intend
to overwrite a file with e.g. `COPY_FILE_ALLOW_DECRYPTED_DESTINATION`.

These functions were affected by the problem:
- CopyFileEx - exposed by Total Commander not being able to overwrite file
- PrivCopyFileEx
- MoveFileWithProgress

Also cover `ERROR_ALREADY_EXISTS` returned by CreateFileW to match Windows
behavior, making the API tests pass.

CORE-10271
2026-06-16 16:10:23 +03:00
Katayama Hirofumi MZ 9e3a4d5be5 [SHLWAPI][SDK] Support IUnknown_ShowBrowserBar (#9161)
Implementing missing features...
JIRA issue: CORE-19278
- Implement
  IUnknown_ShowBrowserBar
  function.
- Modify shlwapi.spec.
- Add prototype into
  <shlwapi_undoc.h>.
2026-06-15 22:44:46 +09:00
Katayama Hirofumi MZ 29ca914bd4 [SHLWAPI] Use <new> std::nothrow (#9150)
Use preferred memory handling on memory
shortage.
JIRA issue: N/A
- Link cppstl instead of cpprt.
- Use <new> new(std::throw) for memory
  allocation.
- Return E_OUTOFMEMORY on allocation
  failure.
- Don't use <stdlib.h> min macro but use
  <cstdlib> __min.
2026-06-15 08:50:15 +09:00
Katayama Hirofumi MZ 1d5d93f05f [SHLWAPI][SHLWAPI_APITEST][SDK] Support MapWin32ErrorToSTG (#9147)
Implementing missing features...
JIRA issue: CORE-19278
- Implement MapWin32ErrorToSTG function.
- Modify shlwapi.spec.
- Add prototype to <shlwapi_undoc.h>.
- Add MapWin32ErrorToSTG testcase.
2026-06-14 11:12:21 +09:00
Whindmar Saksit a83411cfef [SHELL32] Avoid SHRunControlPanel to be Vista compatible (#9114) 2026-06-14 00:24:59 +02:00
Eric Kohl c78c09cfbe [IFMON] Set TCPIP Properties 2026-06-13 17:32:16 +02:00
Katayama Hirofumi MZ 300e1d525d [MSVCRT][CRT][UCRT] Disable intrinsic string functions on MSVC (#9157)
VS2022 version 17.2 and later (`_MSC_VER >= 1932`) added new intrinsic
functions (`strncmp`, `strncpy`, `wcsncmp`, and `wcsncpy`).
As we implement these ourselves, we have to avoid compiler error C2169.

This problem surfaced with a recent GitHub Actions update:
https://github.com/actions/runner-images/issues/14017

Use `#pragma function(...)` to disable new intrinsic functions.
2026-06-13 18:10:15 +03:00
Jose Carlos Jesus f75ca87425 [DEVMGR] Update Portuguese (pt-PT) translation (#9027) 2026-06-10 20:02:49 +03:00
Amine Khaldi c8c275fe63 [JSCRIPT] Attempt to address MSVC_x64 build bot error. 2026-06-10 06:54:51 +00:00
Amine Khaldi 9de28952fb [CRYPTNET] Sync with Wine 10.0. CORE-20594 2026-06-09 20:12:33 +01:00
Amine Khaldi 28ed28dac1 [JSCRIPT] Sync with Wine 10.0. CORE-20605 2026-06-09 20:12:05 +01:00
Timo Kreuzer 43af5398d2 [KERNELBASE] Add kernelbase_ros.dll
This is a termporary solution to provide part of the needed APIs from wine modules, until we have a fully working kernelbase.
This one imports from msvcrt, kernel32 and advapi32.
2026-06-09 17:40:07 +00:00
Timo Kreuzer 4ba2db3c6e [KERNELBASE][PATHCCH] Unhack path.c 2026-06-09 17:40:07 +00:00
Timo Kreuzer 2820072004 [KERNELBASE] Apply reactos fixes from shlwapi SHLoadIndirectString 2026-06-09 17:40:07 +00:00
Timo Kreuzer db16f10a91 [NTDLL_VISTA] Export RtlUnicodeToUTF8N and RtlUTF8ToUnicodeN 2026-06-09 17:40:07 +00:00
Timo Kreuzer 6d0ff7a62a [PSDK] Add timezoneapi.h and use it from winbase.h 2026-06-09 17:40:07 +00:00
Whindmar Saksit f2ef434107 [NETAPI32] Fix NetLocalGroupAddMembers crash because return code was interpreted incorrectly (#9113) 2026-06-09 18:10:30 +02:00
Jose Carlos Jesus fc9e1d11ab [ZIPFLDR] Update and improve Portuguese (pt-PT) translation (#9024) 2026-06-09 15:56:31 +03:00
Katayama Hirofumi MZ 19b19ec305 [USER32][COMCTL32] Edit control: Fix alignment mask (#9115)
Based on JIRA user I_Kill_Bug's "Edit Alignment.patch".
JIRA issue: CORE-20631
- Add (ES_LEFT | ES_RIGHT | ES_CENTER) flags to
  style_change_mask variable.
2026-06-09 13:52:46 +09:00
Carl J. Bialorucki 34bf566dd9 [SYSSETUP][BOOT] Add ReactOS Server Core install type
- Write InstallationType to registry.
- If installing as Server Core, set shell to cmd.exe.
- Rename "Product Option" to "Install Type" and adjust relevant variable names.
- Reserve Nano Server installation type for future use.

JIRA issue: CORE-20645
2026-06-08 10:11:57 -05:00
Eric Kohl 823647a38b [IFMON] Add SetInterfaceProperties() stub and use it in IpSetAddress
- Also move GetInterfaceProperties() around.
- Add required error messages.
2026-06-07 23:16:18 +02:00
Whindmar Saksit 3b58b347bc [EXPLORER][SHELL32] Forward Explorer refresh command to the Start Menu (#9108) 2026-06-07 21:28:13 +02:00