From fc2d4e38004c6a511e92c12cf76ebe6de3b4e827 Mon Sep 17 00:00:00 2001 From: Johannes Anderwald Date: Sun, 29 Jan 2012 23:11:21 +0000 Subject: [PATCH] - Remove cruft from CMakeLists.txt - Silence debug flood - Remove debugging code - Add traces for composite device detection - Don't print device descriptor svn path=/branches/usb-bringup-trunk/; revision=55302 --- drivers/usb/usbehci_new/usb_queue.cpp | 4 ---- drivers/usb/usbehci_new/usbehci.h | 2 +- drivers/usb/usbhub_new/fdo.c | 8 +++++++- drivers/usb/usbohci/CMakeLists.txt | 2 +- 4 files changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/usb/usbehci_new/usb_queue.cpp b/drivers/usb/usbehci_new/usb_queue.cpp index a8ce84b6ce6..acbf1b1c306 100644 --- a/drivers/usb/usbehci_new/usb_queue.cpp +++ b/drivers/usb/usbehci_new/usb_queue.cpp @@ -364,10 +364,6 @@ CUSBQueue::AddUSBRequest( LinkQueueHead(AsyncListQueueHead, QueueHead); KeReleaseSpinLock(m_Lock, OldLevel); - EHCI_USBCMD_CONTENT UsbCmd; - m_Hardware->GetCommandRegister(&UsbCmd); - ASSERT(UsbCmd.AsyncEnable == TRUE); - } diff --git a/drivers/usb/usbehci_new/usbehci.h b/drivers/usb/usbehci_new/usbehci.h index 5e4f5abfaba..a4d18965d38 100644 --- a/drivers/usb/usbehci_new/usbehci.h +++ b/drivers/usb/usbehci_new/usbehci.h @@ -2,7 +2,7 @@ #define USBEHCI_H__ #include -#define YDEBUG +#define NDEBUG #include #include #include diff --git a/drivers/usb/usbhub_new/fdo.c b/drivers/usb/usbhub_new/fdo.c index 1153ed794ee..0b309ce60c1 100644 --- a/drivers/usb/usbhub_new/fdo.c +++ b/drivers/usb/usbhub_new/fdo.c @@ -817,6 +817,7 @@ IsCompositeDevice( // // composite device must have only one configuration // + DPRINT1("IsCompositeDevice bNumConfigurations %x\n", DeviceDescriptor->bNumConfigurations); return FALSE; } @@ -825,6 +826,7 @@ IsCompositeDevice( // // composite device must have multiple interfaces // + DPRINT1("IsCompositeDevice bNumInterfaces %x\n", ConfigurationDescriptor->bNumInterfaces); return FALSE; } @@ -835,6 +837,7 @@ IsCompositeDevice( // ASSERT(DeviceDescriptor->bDeviceSubClass == 0); ASSERT(DeviceDescriptor->bDeviceProtocol == 0); + DPRINT1("IsCompositeDevice: TRUE\n"); return TRUE; } @@ -845,9 +848,12 @@ IsCompositeDevice( // // USB-IF association descriptor // + DPRINT1("IsCompositeDevice: TRUE\n"); return TRUE; } + DPRINT1("DeviceDescriptor bDeviceClass %x bDeviceSubClass %x bDeviceProtocol %x\n", DeviceDescriptor->bDeviceClass, DeviceDescriptor->bDeviceSubClass, DeviceDescriptor->bDeviceProtocol); + // // not a composite device // @@ -1327,7 +1333,7 @@ CreateUsbChildDeviceObject( goto Cleanup; } - DumpFullConfigurationDescriptor(UsbChildExtension->FullConfigDesc); + //DumpFullConfigurationDescriptor(UsbChildExtension->FullConfigDesc); // // Construct all the strings that will described the device to PNP diff --git a/drivers/usb/usbohci/CMakeLists.txt b/drivers/usb/usbohci/CMakeLists.txt index de3deca69d8..53d605c7832 100644 --- a/drivers/usb/usbohci/CMakeLists.txt +++ b/drivers/usb/usbohci/CMakeLists.txt @@ -29,6 +29,6 @@ else() endif(MSVC) set_module_type(usbohci kernelmodedriver) -add_importlibs(usbohci ntoskrnl ks drmk hal usbd) +add_importlibs(usbohci ntoskrnl hal usbd) add_cd_file(TARGET usbohci DESTINATION reactos/system32/drivers NO_CAB FOR all) \ No newline at end of file