From d9db39f82d0824bae7a0abbf874b8ff889aa3b9c Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Fri, 26 Sep 2008 03:23:56 +0000 Subject: [PATCH] - Return early if NBAddNeighbor or RouterAddRoute fails - Fixes coverity error 389 svn path=/branches/aicom-network-fixes/; revision=36526 --- lib/drivers/ip/network/ip.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/drivers/ip/network/ip.c b/lib/drivers/ip/network/ip.c index 2a5c4fd0ebb..d49f15da0a6 100644 --- a/lib/drivers/ip/network/ip.c +++ b/lib/drivers/ip/network/ip.c @@ -242,12 +242,14 @@ VOID IPAddInterfaceRoute( PIP_INTERFACE IF ) { NUD_PERMANENT); if (!NCE) { TI_DbgPrint(MIN_TRACE, ("Could not create NCE.\n")); + return; } AddrWidenAddress( &NetworkAddress, &IF->Unicast, &IF->Netmask ); if (!RouterAddRoute(&NetworkAddress, &IF->Netmask, NCE, 1)) { TI_DbgPrint(MIN_TRACE, ("Could not add route due to insufficient resources.\n")); + return; } /* Allow TCP to hang some configuration on this interface */