From cbb6aa83e6777afbc1ed914395694da3e4ce13b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Herv=C3=A9=20Poussineau?= Date: Sun, 7 May 2006 09:32:56 +0000 Subject: [PATCH] Fix buffer overflow (spotted by Detlef Riekenberg in wine-devel ML) svn path=/trunk/; revision=21823 --- reactos/dll/win32/setupapi/parser.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/reactos/dll/win32/setupapi/parser.c b/reactos/dll/win32/setupapi/parser.c index e6934adad06..84448106528 100644 --- a/reactos/dll/win32/setupapi/parser.c +++ b/reactos/dll/win32/setupapi/parser.c @@ -953,10 +953,10 @@ static struct inf_file *parse_file( HANDLE handle, UINT *error_line ) else { WCHAR *new_buff = (WCHAR *)buffer; - /* Some UNICODE files may start with the UNICODE marker */ + /* UCS-16 files should start with the Unicode BOM; we should skip it */ if (*new_buff == 0xfeff) new_buff++; - err = parse_buffer( file, new_buff, (WCHAR *)((char *)new_buff + size), error_line ); + err = parse_buffer( file, new_buff, (WCHAR *)((char *)buffer + size), error_line ); } if (!err) /* now check signature */