diff --git a/reactos/win32ss/user/ntuser/clipboard.c b/reactos/win32ss/user/ntuser/clipboard.c index 5e153dcf4ff..ba1c3232aa6 100644 --- a/reactos/win32ss/user/ntuser/clipboard.c +++ b/reactos/win32ss/user/ntuser/clipboard.c @@ -346,6 +346,43 @@ UserEmptyClipboardData(PWINSTATION_OBJECT pWinSta) pWinSta->cNumClipFormats = 0; } +/* UserClipboardRelease is called from IntSendDestroyMsg in window.c */ +VOID FASTCALL +UserClipboardRelease(PWND pWindow) +{ + PWINSTATION_OBJECT pWinStaObj; + + pWinStaObj = IntGetWinStaForCbAccess(); + if (!pWinStaObj) + return; + + co_IntSendMessage(pWinStaObj->spwndClipOwner->head.h, WM_RENDERALLFORMATS, 0, 0); + + /* If the window being destroyed is the current clipboard owner... */ + if (pWindow == pWinStaObj->spwndClipOwner) + { + /* ... make it release the clipboard */ + pWinStaObj->spwndClipOwner = NULL; + } + + if (pWinStaObj->fClipboardChanged) + { + /* Add synthesized formats - they are rendered later */ + IntAddSynthesizedFormats(pWinStaObj); + + /* Notify viewer windows in chain */ + pWinStaObj->fClipboardChanged = FALSE; + if (pWinStaObj->spwndClipViewer) + { + TRACE("Clipboard: sending WM_DRAWCLIPBOARD to %p\n", pWinStaObj->spwndClipViewer->head.h); + // For 32-bit applications this message is sent as a notification + co_IntSendMessageNoWait(pWinStaObj->spwndClipViewer->head.h, WM_DRAWCLIPBOARD, 0, 0); + } + } + + ObDereferenceObject(pWinStaObj); +} + /* UserClipboardFreeWindow is called from co_UserFreeWindow in window.c */ VOID FASTCALL UserClipboardFreeWindow(PWND pWindow) @@ -356,6 +393,12 @@ UserClipboardFreeWindow(PWND pWindow) if (!pWinStaObj) return; + if (pWindow == pWinStaObj->spwndClipOwner) + { + /* The owner window was destroyed */ + pWinStaObj->spwndClipOwner = NULL; + } + /* Check if clipboard is not locked by this window, if yes, unlock it */ if (pWindow == pWinStaObj->spwndClipOpen) { @@ -363,11 +406,6 @@ UserClipboardFreeWindow(PWND pWindow) pWinStaObj->spwndClipOpen = NULL; pWinStaObj->ptiClipLock = NULL; } - if (pWindow == pWinStaObj->spwndClipOwner) - { - /* The owner window was destroyed */ - pWinStaObj->spwndClipOwner = NULL; - } /* Remove window from window chain */ if (pWindow == pWinStaObj->spwndClipViewer) pWinStaObj->spwndClipViewer = NULL; @@ -500,13 +538,13 @@ UserCloseClipboard(VOID) IntAddSynthesizedFormats(pWinStaObj); /* Notify viewer windows in chain */ + pWinStaObj->fClipboardChanged = FALSE; if (pWinStaObj->spwndClipViewer) { TRACE("Clipboard: sending WM_DRAWCLIPBOARD to %p\n", pWinStaObj->spwndClipViewer->head.h); - co_IntSendMessage(pWinStaObj->spwndClipViewer->head.h, WM_DRAWCLIPBOARD, 0, 0); + // For 32-bit applications this message is sent as a notification + co_IntSendMessageNoWait(pWinStaObj->spwndClipViewer->head.h, WM_DRAWCLIPBOARD, 0, 0); } - - pWinStaObj->fClipboardChanged = FALSE; } cleanup: @@ -629,6 +667,7 @@ UserEmptyClipboard(VOID) if (pWinStaObj->spwndClipOwner) { TRACE("Clipboard: WM_DESTROYCLIPBOARD to %p\n", pWinStaObj->spwndClipOwner->head.h); + // For 32-bit applications this message is sent as a notification co_IntSendMessageNoWait(pWinStaObj->spwndClipOwner->head.h, WM_DESTROYCLIPBOARD, 0, 0); } @@ -1053,6 +1092,15 @@ NtUserSetClipboardViewer(HWND hWndNewViewer) /* Set new viewer window */ pWinStaObj->spwndClipViewer = pWindow; + /* Notify viewer windows in chain */ + pWinStaObj->fClipboardChanged = FALSE; + if (pWinStaObj->spwndClipViewer) + { + TRACE("Clipboard: sending WM_DRAWCLIPBOARD to %p\n", pWinStaObj->spwndClipViewer->head.h); + // For 32-bit applications this message is sent as a notification + co_IntSendMessageNoWait(pWinStaObj->spwndClipViewer->head.h, WM_DRAWCLIPBOARD, 0, 0); + } + cleanup: if (pWinStaObj) ObDereferenceObject(pWinStaObj); diff --git a/reactos/win32ss/user/ntuser/clipboard.h b/reactos/win32ss/user/ntuser/clipboard.h index b983a177b83..5cbc08c17d3 100644 --- a/reactos/win32ss/user/ntuser/clipboard.h +++ b/reactos/win32ss/user/ntuser/clipboard.h @@ -10,6 +10,9 @@ typedef struct _CLIP UINT APIENTRY UserEnumClipboardFormats(UINT uFormat); +VOID FASTCALL +UserClipboardRelease(PWND pWindow); + VOID FASTCALL UserClipboardFreeWindow(PWND pWindow); diff --git a/reactos/win32ss/user/ntuser/window.c b/reactos/win32ss/user/ntuser/window.c index 9ca01b3db6a..f89f08ee5ad 100644 --- a/reactos/win32ss/user/ntuser/window.c +++ b/reactos/win32ss/user/ntuser/window.c @@ -424,10 +424,14 @@ static void IntSendDestroyMsg(HWND hWnd) } } - /* - * Send the WM_DESTROY to the window. - */ + /* If the window being destroyed is the current clipboard owner... */ + if (ti->ppi->prpwinsta != NULL && Window == ti->ppi->prpwinsta->spwndClipOwner) + { + /* ... make it release the clipboard */ + UserClipboardRelease(Window); + } + /* Send the WM_DESTROY to the window */ co_IntSendMessage(hWnd, WM_DESTROY, 0, 0); /* @@ -554,6 +558,8 @@ LRESULT co_UserFreeWindow(PWND Window, co_IntSendMessage(UserHMGetHandle(Window), WM_NCDESTROY, 0, 0); } + UserClipboardFreeWindow(Window); + DestroyTimersForWindow(ThreadData, Window); /* Unregister hot keys */ @@ -665,8 +671,6 @@ LRESULT co_UserFreeWindow(PWND Window, UserDereferenceObject(Window); - UserClipboardFreeWindow(Window); - return 0; }