From c6298321a34e2cecf84fa1b810f0dcc16c269ffe Mon Sep 17 00:00:00 2001 From: Serge Gautherie Date: Sun, 14 Jun 2020 13:49:22 +0200 Subject: [PATCH] [NTUSER] Fix IntDefWindowProc()'s WM_MOUSEACTIVATE case (#7038) CORE-17545 Clang 13.0.1 was warning about broken 'Ret' handling. Also remove an unrelated redundant 'else ...'. Addendum to commit 6dfa71c487 (r68904). --- win32ss/user/ntuser/defwnd.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/win32ss/user/ntuser/defwnd.c b/win32ss/user/ntuser/defwnd.c index 1f444803e43..33911c5ea5b 100644 --- a/win32ss/user/ntuser/defwnd.c +++ b/win32ss/user/ntuser/defwnd.c @@ -566,7 +566,6 @@ IntDefWindowProc( lResult = (LRESULT) (Wnd->strName.Length / sizeof(WCHAR)); } } - else lResult = 0L; break; } @@ -1038,12 +1037,15 @@ IntDefWindowProc( case WM_MOUSEACTIVATE: if (Wnd->style & WS_CHILD) { - LONG Ret; HWND hwndParent; PWND pwndParent = IntGetParent(Wnd); hwndParent = pwndParent ? UserHMGetHandle(pwndParent) : NULL; - if (hwndParent) Ret = co_IntSendMessage(hwndParent, WM_MOUSEACTIVATE, wParam, lParam); - if (Ret) return (Ret); + if (hwndParent) + { + lResult = co_IntSendMessage(hwndParent, WM_MOUSEACTIVATE, wParam, lParam); + if (lResult) + break; + } } return ( (HIWORD(lParam) == WM_LBUTTONDOWN && LOWORD(lParam) == HTCAPTION) ? MA_NOACTIVATE : MA_ACTIVATE );