From 6db46bea8e39d73d028323187565ab91e7acbf52 Mon Sep 17 00:00:00 2001 From: Christoph von Wittich Date: Thu, 24 Aug 2006 16:06:12 +0000 Subject: [PATCH] fixed some warnings svn path=/trunk/; revision=23686 --- reactos/drivers/usb/nt4compat/usbdriver/cbi.c | 2 ++ .../drivers/usb/nt4compat/usbdriver/compdrv.c | 6 +++++ .../drivers/usb/nt4compat/usbdriver/devmgr.c | 5 ++-- reactos/drivers/usb/nt4compat/usbdriver/etd.c | 4 +++- .../drivers/usb/nt4compat/usbdriver/gendrv.c | 5 +++- reactos/drivers/usb/nt4compat/usbdriver/hub.c | 23 ++++++++++++++++++- .../drivers/usb/nt4compat/usbdriver/umss.c | 6 +++++ reactos/drivers/usb/nt4compat/usbdriver/usb.c | 4 ++++ 8 files changed, 50 insertions(+), 5 deletions(-) diff --git a/reactos/drivers/usb/nt4compat/usbdriver/cbi.c b/reactos/drivers/usb/nt4compat/usbdriver/cbi.c index 32f65518ec0..0737b3b2ec6 100644 --- a/reactos/drivers/usb/nt4compat/usbdriver/cbi.c +++ b/reactos/drivers/usb/nt4compat/usbdriver/cbi.c @@ -38,6 +38,8 @@ umss_class_specific_request(IN PUMSS_DEVICE_EXTENSION pdev_ext, PURB purb; NTSTATUS status; + UNREFERENCED_PARAMETER(dir); + purb = usb_alloc_mem(NonPagedPool, sizeof(URB)); // Build URB for the ADSC command UsbBuildVendorRequest(purb, diff --git a/reactos/drivers/usb/nt4compat/usbdriver/compdrv.c b/reactos/drivers/usb/nt4compat/usbdriver/compdrv.c index 1cc6a539e9e..d978d6a402e 100644 --- a/reactos/drivers/usb/nt4compat/usbdriver/compdrv.c +++ b/reactos/drivers/usb/nt4compat/usbdriver/compdrv.c @@ -66,6 +66,8 @@ compdev_driver_init(PUSB_DEV_MANAGER dev_mgr, PUSB_DRIVER pdriver) BOOLEAN compdev_driver_destroy(PUSB_DEV_MANAGER dev_mgr, PUSB_DRIVER pdriver) { + UNREFERENCED_PARAMETER(dev_mgr); + UNREFERENCED_PARAMETER(pdriver); return TRUE; } @@ -196,6 +198,10 @@ compdev_event_select_if_driver(PUSB_DEV pdev, ULONG event, ULONG context, ULONG PUSB_DEV_MANAGER dev_mgr; DEV_HANDLE dev_handle; + UNREFERENCED_PARAMETER(param); + UNREFERENCED_PARAMETER(context); + UNREFERENCED_PARAMETER(event); + if (pdev == NULL) return; diff --git a/reactos/drivers/usb/nt4compat/usbdriver/devmgr.c b/reactos/drivers/usb/nt4compat/usbdriver/devmgr.c index 23fb8e82aef..4885b646298 100644 --- a/reactos/drivers/usb/nt4compat/usbdriver/devmgr.c +++ b/reactos/drivers/usb/nt4compat/usbdriver/devmgr.c @@ -317,8 +317,9 @@ dev_mgr_thread(PVOID context) continue; } - // usb_dbg_print( DBGLVL_MAXIMUM, ( "dev_mgr_thread(): current element in event list is 0x%x\n", \ - // dbg_count_list( &dev_mgr->event_list ) ) ); + /* + usb_dbg_print( DBGLVL_MAXIMUM, ( "dev_mgr_thread(): current element in event list is 0x%x\n", \ + dbg_count_list( &dev_mgr->event_list ) ) ); */ dev_mgr_inited = TRUE; //since we have post one event, if this statement is executed, dev_mgr_event_init must be called sometime later or earlier diff --git a/reactos/drivers/usb/nt4compat/usbdriver/etd.c b/reactos/drivers/usb/nt4compat/usbdriver/etd.c index 04ca287f9f7..9bcefd45cd4 100644 --- a/reactos/drivers/usb/nt4compat/usbdriver/etd.c +++ b/reactos/drivers/usb/nt4compat/usbdriver/etd.c @@ -140,6 +140,8 @@ elem_list_init_elem_list(PEHCI_ELEM_LIST plist, LONG init_flags, PVOID context, PEHCI_FSTN pfstn; PINIT_ELEM_LIST_CONTEXT pinit_ctx; + UNREFERENCED_PARAMETER(count); + if (plist == NULL || context == NULL) return FALSE; @@ -465,7 +467,7 @@ elem_pool_is_empty(PEHCI_ELEM_POOL pool) if (pool == NULL) return TRUE; pel = pool->elem_lists[0]; - return (pool->list_count == 1 && pool->free_count == pel->get_total_count(pel)); + return (BOOLEAN) (pool->list_count == 1 && pool->free_count == pel->get_total_count(pel)); } LONG diff --git a/reactos/drivers/usb/nt4compat/usbdriver/gendrv.c b/reactos/drivers/usb/nt4compat/usbdriver/gendrv.c index 04226a3ee86..8d7a789f3ee 100644 --- a/reactos/drivers/usb/nt4compat/usbdriver/gendrv.c +++ b/reactos/drivers/usb/nt4compat/usbdriver/gendrv.c @@ -288,6 +288,9 @@ gendrv_event_select_driver(PUSB_DEV pdev, //always null. we do not use thi USE_BASIC_NON_PENDING_IRQL; + UNREFERENCED_PARAMETER(context); + UNREFERENCED_PARAMETER(event); + if (pdev == NULL) return FALSE; @@ -1350,7 +1353,7 @@ gendrv_delete_device(PUSB_DEV_MANAGER dev_mgr, PDEVICE_OBJECT dev_obj) pdev_ext = (PGENDRV_DEVICE_EXTENSION) dev_obj->DeviceExtension; pdrvr = pdev_ext->pdriver; pdrvr_ext = (PGENDRV_DRVR_EXTENSION) pdrvr->driver_ext; - is_if = if_dev(dev_obj); + is_if = (BOOLEAN) if_dev(dev_obj); if (is_if == FALSE) sprintf(dev_name, "\\DosDevices\\gendev%d", (int)pdev_ext->dev_id); else diff --git a/reactos/drivers/usb/nt4compat/usbdriver/hub.c b/reactos/drivers/usb/nt4compat/usbdriver/hub.c index 8db408708ce..e5e14b48722 100644 --- a/reactos/drivers/usb/nt4compat/usbdriver/hub.c +++ b/reactos/drivers/usb/nt4compat/usbdriver/hub.c @@ -182,6 +182,10 @@ destroy_event_pool(PUSB_EVENT_POOL pool) VOID event_list_default_process_event(PUSB_DEV pdev, ULONG event, ULONG context, ULONG param) { + UNREFERENCED_PARAMETER(param); + UNREFERENCED_PARAMETER(context); + UNREFERENCED_PARAMETER(event); + UNREFERENCED_PARAMETER(pdev); } //---------------------------------------------------------- @@ -341,6 +345,8 @@ psq_push(PPORT_STATUS_QUEUE psq, ULONG status) BOOLEAN hub_driver_init(PUSB_DEV_MANAGER dev_mgr, PUSB_DRIVER pdriver) { + UNREFERENCED_PARAMETER(dev_mgr); + //init driver structure, no PNP table functions pdriver->driver_desc.flags = USB_DRIVER_FLAG_DEV_CAPABLE; pdriver->driver_desc.vendor_id = 0xffff; // USB Vendor ID @@ -376,6 +382,8 @@ hub_driver_init(PUSB_DEV_MANAGER dev_mgr, PUSB_DRIVER pdriver) BOOLEAN hub_driver_destroy(PUSB_DEV_MANAGER dev_mgr, PUSB_DRIVER pdriver) { + UNREFERENCED_PARAMETER(dev_mgr); + pdriver->driver_ext = NULL; return TRUE; } @@ -389,6 +397,8 @@ hub_reset_pipe_completion(PURB purb, //only for reference, can not be release USE_BASIC_NON_PENDING_IRQL; + UNREFERENCED_PARAMETER(context); + if (purb == NULL) { return; @@ -744,7 +754,7 @@ hub_clear_port_feature_completion(PURB purb, PVOID context) lock_dev(pdev, TRUE); dev_mgr = dev_mgr_from_dev(pdev); hcd = pdev->hcd; - brh = (dev_class(pdev) == USB_DEV_CLASS_ROOT_HUB); + brh = (BOOLEAN) (dev_class(pdev) == USB_DEV_CLASS_ROOT_HUB); if (usb_error(purb->status)) { @@ -1003,6 +1013,8 @@ hub_event_examine_status_que(PUSB_DEV pdev, USE_NON_PENDING_IRQL; + UNREFERENCED_PARAMETER(event); + if (pdev == NULL || context == 0 || param == 0) return; @@ -1191,6 +1203,8 @@ hub_event_dev_stable(PUSB_DEV pdev, USE_NON_PENDING_IRQL; + UNREFERENCED_PARAMETER(event); + if (pdev == NULL || context == 0 || param == 0) return; @@ -1431,6 +1445,8 @@ hub_disable_port_completion(PURB purb, PVOID pcontext) PUSB_ENDPOINT pendp; PUSB_CTRL_SETUP_PACKET psetup; + UNREFERENCED_PARAMETER(pcontext); + if (purb == NULL) return; @@ -2482,6 +2498,8 @@ dev_mgr_score_driver_for_dev(PUSB_DEV_MANAGER dev_mgr, PUSB_DRIVER pdriver, PUSB { LONG credit = 0; + UNREFERENCED_PARAMETER(dev_mgr); + //assume supports all the sub_class are supported if sub_class is zero if (pdriver->driver_desc.dev_class == pdev_desc->bDeviceClass) { @@ -3108,6 +3126,8 @@ LBL_OUT: BOOLEAN hub_stop(PUSB_DEV_MANAGER dev_mgr, DEV_HANDLE dev_handle) { + UNREFERENCED_PARAMETER(dev_mgr); + UNREFERENCED_PARAMETER(dev_handle); return TRUE; } @@ -3309,6 +3329,7 @@ hub_event_clear_tt_buffer(PUSB_DEV pdev, //always null. we do not use thi ULONG context, ULONG param) { + UNREFERENCED_PARAMETER(event); hub_clear_tt_buffer(pdev, *((PURB_HS_PIPE_CONTENT) & context), (UCHAR) param); return; } diff --git a/reactos/drivers/usb/nt4compat/usbdriver/umss.c b/reactos/drivers/usb/nt4compat/usbdriver/umss.c index 1fefbe77d4f..d3d64db4ce3 100644 --- a/reactos/drivers/usb/nt4compat/usbdriver/umss.c +++ b/reactos/drivers/usb/nt4compat/usbdriver/umss.c @@ -630,6 +630,8 @@ umss_start_create_device(IN PVOID Parameter) BOOLEAN umss_stop(PUSB_DEV_MANAGER dev_mgr, DEV_HANDLE dev_handle) { + UNREFERENCED_PARAMETER(dev_handle); + UNREFERENCED_PARAMETER(dev_mgr); return TRUE; } @@ -1766,6 +1768,8 @@ umss_load_class_driver(PVOID context) NTSTATUS status; UNICODE_STRING unicode_string; + UNREFERENCED_PARAMETER(context); + // // let's load the class driver // @@ -1853,6 +1857,8 @@ umss_get_if_driver_info(PUSB_DEV_MANAGER dev_mgr, PUSB_DEV pdev, DEV_HANDLE if_h ULONG if_idx; USE_BASIC_NON_PENDING_IRQL; + UNREFERENCED_PARAMETER(dev_mgr); + if_idx = if_idx_from_handle(if_handle); if (if_idx >= 4) // max interfaces per config supports. defined in td.h return NULL; diff --git a/reactos/drivers/usb/nt4compat/usbdriver/usb.c b/reactos/drivers/usb/nt4compat/usbdriver/usb.c index 67b05b020f9..e7eb2edb599 100644 --- a/reactos/drivers/usb/nt4compat/usbdriver/usb.c +++ b/reactos/drivers/usb/nt4compat/usbdriver/usb.c @@ -794,6 +794,8 @@ usb_config_dev_completion(PURB purb, PVOID context) USE_BASIC_NON_PENDING_IRQL; + UNREFERENCED_PARAMETER(context); + if (purb == NULL) { return; @@ -1260,6 +1262,8 @@ usb_set_interface_completion(PURB purb, PVOID context) USE_BASIC_NON_PENDING_IRQL; + UNREFERENCED_PARAMETER(context); + if (purb == NULL) return;