From 6d8d3402b354b62fe26bf76aebd5cbc5af0c267b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Herm=C3=A8s=20B=C3=A9lusca-Ma=C3=AFto?=
 <hermes.belusca-maito@reactos.org>
Date: Tue, 28 Jun 2016 19:21:08 +0000
Subject: [PATCH] [SUBST]: CORE-10681 #comment Apply part of Peter Hater's
 patch proposed in CORE-10681, that is, fixing the usage of QueryDosDevice
 API, but without the new IsDriveUsed functionality. (r71692)

svn path=/trunk/; revision=71692
---
 reactos/base/system/subst/subst.c | 82 ++++++++++++++-----------------
 1 file changed, 37 insertions(+), 45 deletions(-)

diff --git a/reactos/base/system/subst/subst.c b/reactos/base/system/subst/subst.c
index 903d59b9ef0..46680737a2d 100644
--- a/reactos/base/system/subst/subst.c
+++ b/reactos/base/system/subst/subst.c
@@ -75,40 +75,37 @@ BOOLEAN IsSubstedDrive(TCHAR *Drive)
     if (_tcslen(Drive) > 2)
         return FALSE;
 
-    dwSize = sizeof(TCHAR) * MAX_PATH;
-    lpTargetPath = (LPTSTR) malloc(sizeof(TCHAR) * MAX_PATH);
-    if ( lpTargetPath)
-    {
-        CharCount = QueryDosDevice(Drive,
-                                   lpTargetPath,
-                                   dwSize / sizeof(TCHAR));
-        while (! CharCount &&
-               GetLastError() == ERROR_INSUFFICIENT_BUFFER)
-        {
-            free(lpTargetPath);
-            dwSize *= 2;
-            lpTargetPath = (LPTSTR) malloc(dwSize);
-            if (lpTargetPath)
-            {
-                CharCount = QueryDosDevice(Drive,
-                                           lpTargetPath,
-                                           dwSize / sizeof(TCHAR));
-            }
-        }
+    dwSize = MAX_PATH;
+    lpTargetPath = (LPTSTR)malloc(sizeof(TCHAR) * dwSize);
+    if (!lpTargetPath)
+        return FALSE;
 
-        if (CharCount)
+    CharCount = QueryDosDevice(Drive,
+                               lpTargetPath,
+                               dwSize);
+    while (!CharCount &&
+           GetLastError() == ERROR_INSUFFICIENT_BUFFER)
+    {
+        lpTargetPath = (LPTSTR)realloc(lpTargetPath, sizeof(TCHAR) * dwSize);
+        if (lpTargetPath)
         {
-            if ( _tcsncmp(lpTargetPath, _T("\\??\\"), 4) == 0 &&
-                ( (lpTargetPath[4] >= _T('A') &&
-                lpTargetPath[4] <= _T('Z')) ||
-                 (lpTargetPath[4] >= _T('a') &&
-                lpTargetPath[4] <= _T('z')) ) )
-            {
-                Result = TRUE;
-            }
+            CharCount = QueryDosDevice(Drive,
+                                       lpTargetPath,
+                                       dwSize);
         }
-        free(lpTargetPath);
     }
+
+    if (CharCount)
+    {
+        Result = _tcsncmp(lpTargetPath, _T("\\??\\"), 4) == 0 &&
+            ( (lpTargetPath[4] >= _T('A') &&
+            lpTargetPath[4] <= _T('Z')) ||
+             (lpTargetPath[4] >= _T('a') &&
+            lpTargetPath[4] <= _T('z')) );
+    }
+
+    free(lpTargetPath);
+
     return Result;
 }
 
@@ -119,9 +116,9 @@ void DumpSubstedDrives(void)
     DWORD CharCount, dwSize;
     INT i = 0;
 
-    dwSize = sizeof(TCHAR) * MAX_PATH;
-    lpTargetPath = (LPTSTR) malloc(sizeof(TCHAR) * MAX_PATH);
-    if (! lpTargetPath)
+    dwSize = MAX_PATH;
+    lpTargetPath = (LPTSTR)malloc(sizeof(TCHAR) * dwSize);
+    if (!lpTargetPath)
         return;
 
     while (i < 26)
@@ -129,27 +126,20 @@ void DumpSubstedDrives(void)
         Drive[0] = _T('A') + i;
         CharCount = QueryDosDevice(Drive,
                                    lpTargetPath,
-                                   dwSize / sizeof(TCHAR));
-        while (! CharCount &&
+                                   dwSize);
+        while (!CharCount &&
                GetLastError() == ERROR_INSUFFICIENT_BUFFER)
         {
-            free(lpTargetPath);
-            dwSize *= 2;
-            lpTargetPath = (LPTSTR) malloc(dwSize);
+            lpTargetPath = (LPTSTR)realloc(lpTargetPath, sizeof(TCHAR) * dwSize);
             if (lpTargetPath)
             {
                 CharCount = QueryDosDevice(Drive,
                                            lpTargetPath,
-                                           dwSize / sizeof(TCHAR));
+                                           dwSize);
             }
         }
 
-        if (! CharCount)
-        {
-            i++;
-            continue;
-        }
-        else
+        if (CharCount)
         {
             if ( _tcsncmp(lpTargetPath, _T("\\??\\"), 4) == 0 &&
                 ( (lpTargetPath[4] >= _T('A') &&
@@ -162,8 +152,10 @@ void DumpSubstedDrives(void)
                          lpTargetPath + 4);
             }
         }
+
         i++;
     }
+
     free(lpTargetPath);
 }