From 699702d6ce66f1b5ef3a028ffc638995c04caef0 Mon Sep 17 00:00:00 2001
From: Gunnar Dalsnes <hardon@online.no>
Date: Fri, 24 Dec 2004 02:09:12 +0000
Subject: [PATCH] -add some asserts to catch abuse (double insertions,
 unititialized items etc.) -add asserts for KeRemoveQueue NTSTATUS returns

svn path=/trunk/; revision=12311
---
 reactos/ntoskrnl/ex/work.c | 23 +++++++++++++++++++++--
 1 file changed, 21 insertions(+), 2 deletions(-)

diff --git a/reactos/ntoskrnl/ex/work.c b/reactos/ntoskrnl/ex/work.c
index 272b20c0469..7566cd0e331 100644
--- a/reactos/ntoskrnl/ex/work.c
+++ b/reactos/ntoskrnl/ex/work.c
@@ -1,4 +1,4 @@
-/* $Id: work.c,v 1.23 2004/11/21 18:38:51 gdalsnes Exp $
+/* $Id: work.c,v 1.24 2004/12/24 02:09:12 gdalsnes Exp $
  *
  * COPYRIGHT:          See COPYING in the top level directory
  * PROJECT:            ReactOS kernel
@@ -53,6 +53,25 @@ ExWorkerThreadEntryPoint(IN PVOID context)
    while (TRUE) 
    {
       current = KeRemoveQueue( (PKQUEUE)context, KernelMode, NULL );
+      
+      /* can't happend since we do a KernelMode wait (and we're a system thread) */
+      ASSERT((NTSTATUS)current != STATUS_USER_APC);
+      
+      /* this should never happend either, since we wait with NULL timeout,
+       * but there's a slight possibility that STATUS_TIMEOUT is returned
+       * at queue rundown in NT (unlikely) -Gunnar
+       */
+      ASSERT((NTSTATUS)current != STATUS_TIMEOUT);
+      
+      /* based on INVALID_WORK_QUEUE_ITEM bugcheck desc. */
+      if (current->Flink == NULL || current->Blink == NULL)
+      {
+         KeBugCheck(INVALID_WORK_QUEUE_ITEM);
+      }
+      
+      /* "reinitialize" item (same as done in ExInitializeWorkItem) */
+      current->Flink = NULL;
+      
       item = CONTAINING_RECORD( current, WORK_QUEUE_ITEM, List);
       item->WorkerRoutine(item->Parameter);
       
@@ -126,7 +145,7 @@ ExQueueWorkItem (PWORK_QUEUE_ITEM	WorkItem,
 {
     ASSERT(WorkItem!=NULL);
     ASSERT_IRQL(DISPATCH_LEVEL);
-   
+    ASSERT(WorkItem->List.Flink == NULL);
    /*
     * Insert the item in the appropiate queue and wake up any thread
     * waiting for something to do