From 659e7c97dfa37ff6cb503c1678c53fde52eeaebb Mon Sep 17 00:00:00 2001 From: Aleksey Bragin Date: Thu, 18 May 2006 12:16:53 +0000 Subject: [PATCH] [AUDIT] ntoskrnl/dbgk (according to functions_list.txt in audited branch comments by Alex Ionescu, and comments by me) - debug.c: Clean/trivial implementation based on the object's structure. I merely create it and then initailize all its members. Other functions are stubs - dbgkutil.c: Code is #if0'ed, and doesn't belong to Alex Ionescu. Author is unknown. - Unified / prettified formatting, STDCALL -> NTAPI svn path=/trunk/; revision=21931 --- reactos/ntoskrnl/dbgk/dbgkutil.c | 46 ++++++++++++++++---------------- reactos/ntoskrnl/dbgk/debug.c | 12 ++++----- 2 files changed, 29 insertions(+), 29 deletions(-) diff --git a/reactos/ntoskrnl/dbgk/dbgkutil.c b/reactos/ntoskrnl/dbgk/dbgkutil.c index d9ed8aba6e7..b8aec4c212c 100644 --- a/reactos/ntoskrnl/dbgk/dbgkutil.c +++ b/reactos/ntoskrnl/dbgk/dbgkutil.c @@ -16,41 +16,41 @@ /* FUNCTIONS *****************************************************************/ VOID -STDCALL +NTAPI DbgkCreateThread(PVOID StartAddress) { #if 0 - LPC_DBG_MESSAGE Message; - LPC_DBG_MESSAGE Reply; - NTSTATUS Status; + LPC_DBG_MESSAGE Message; + LPC_DBG_MESSAGE Reply; + NTSTATUS Status; - if (PsGetCurrentThread()->ThreadsProcess->DebugPort == NULL) + if (PsGetCurrentThread()->ThreadsProcess->DebugPort == NULL) { - return; + return; } - Message.Header.MessageSize = sizeof(LPC_DBG_MESSAGE); - Message.Header.DataSize = sizeof(LPC_DBG_MESSAGE) - - sizeof(LPC_MESSAGE); - Message.Type = DBG_EVENT_CREATE_THREAD; - Message.Status = STATUS_SUCCESS; - Message.Data.CreateThread.Reserved = 0; - Message.Data.CreateThread.StartAddress = StartAddress; + Message.Header.MessageSize = sizeof(LPC_DBG_MESSAGE); + Message.Header.DataSize = sizeof(LPC_DBG_MESSAGE) - + sizeof(LPC_MESSAGE); + Message.Type = DBG_EVENT_CREATE_THREAD; + Message.Status = STATUS_SUCCESS; + Message.Data.CreateThread.Reserved = 0; + Message.Data.CreateThread.StartAddress = StartAddress; - /* FIXME: Freeze all threads in process */ + /* FIXME: Freeze all threads in process */ - /* Send the message to the process's debug port and wait for a reply */ - Status = - LpcSendDebugMessagePort(PsGetCurrentThread()->ThreadsProcess->DebugPort, - &Message, - &Reply); - if (!NT_SUCCESS(Status)) + /* Send the message to the process's debug port and wait for a reply */ + Status = + LpcSendDebugMessagePort(PsGetCurrentThread()->ThreadsProcess->DebugPort, + &Message, + &Reply); + if (!NT_SUCCESS(Status)) { - return; + return; } - /* FIXME: Examine reply */ - return; + /* FIXME: Examine reply */ + return; #endif } diff --git a/reactos/ntoskrnl/dbgk/debug.c b/reactos/ntoskrnl/dbgk/debug.c index 2a90a9aa08a..1c67cb15fdd 100644 --- a/reactos/ntoskrnl/dbgk/debug.c +++ b/reactos/ntoskrnl/dbgk/debug.c @@ -17,7 +17,7 @@ POBJECT_TYPE DbgkDebugObjectType; /* FUNCTIONS *****************************************************************/ NTSTATUS -STDCALL +NTAPI NtCreateDebugObject(OUT PHANDLE DebugHandle, IN ACCESS_MASK DesiredAccess, IN POBJECT_ATTRIBUTES ObjectAttributes, @@ -103,7 +103,7 @@ NtCreateDebugObject(OUT PHANDLE DebugHandle, } NTSTATUS -STDCALL +NTAPI NtWaitForDebugEvent(IN HANDLE DebugObject, // Debug object handle must grant DEBUG_OBJECT_WAIT_STATE_CHANGE access. IN BOOLEAN Alertable, IN PLARGE_INTEGER Timeout OPTIONAL, @@ -116,7 +116,7 @@ NtWaitForDebugEvent(IN HANDLE DebugObject, // Debug object handle must grant DEB } NTSTATUS -STDCALL +NTAPI NtDebugContinue(IN HANDLE DebugObject, // Debug object handle must grant DEBUG_OBJECT_WAIT_STATE_CHANGE access. IN PCLIENT_ID AppClientId, IN NTSTATUS ContinueStatus) @@ -128,7 +128,7 @@ NtDebugContinue(IN HANDLE DebugObject, // Debug object handle must grant DEBU } NTSTATUS -STDCALL +NTAPI NtDebugActiveProcess(IN HANDLE Process, // Process handle must grant PROCESS_SUSPEND_RESUME access. IN HANDLE DebugObject) // Debug object handle must grant DEBUG_OBJECT_ADD_REMOVE_PROCESS access. { @@ -139,7 +139,7 @@ NtDebugActiveProcess(IN HANDLE Process, // Process handle must grant PROCESS } NTSTATUS -STDCALL +NTAPI NtRemoveProcessDebug(IN HANDLE Process, // Process handle must grant PROCESS_SUSPEND_RESUME access. IN HANDLE DebugObject) // Debug object handle must grant DEBUG_OBJECT_ADD_REMOVE_PROCESS access. { @@ -150,7 +150,7 @@ NtRemoveProcessDebug(IN HANDLE Process, // Process handle must grant PROCESS } NTSTATUS -STDCALL +NTAPI NtSetInformationDebugObject(IN HANDLE DebugObject, // Debug object handle need not grant any particular access right. IN DEBUGOBJECTINFOCLASS DebugObjectInformationClass, IN PVOID DebugInformation,