From 6276f8ea513aca7653360ded38580de414aa0f97 Mon Sep 17 00:00:00 2001 From: Art Yerkes Date: Tue, 23 Sep 2008 08:43:49 +0000 Subject: [PATCH] Fix possible overrun of the last byte of dbuf (coverity 552). svn path=/trunk/; revision=36419 --- reactos/base/services/dhcp/dhclient.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/reactos/base/services/dhcp/dhclient.c b/reactos/base/services/dhcp/dhclient.c index b71d87337fd..9ff67ecd4aa 100644 --- a/reactos/base/services/dhcp/dhclient.c +++ b/reactos/base/services/dhcp/dhclient.c @@ -480,9 +480,9 @@ void set_name_servers( struct client_lease *new_lease ) { RegSetValueEx( RegKey, "DhcpNameServer", 0, REG_SZ, (LPBYTE)nsbuf, strlen(nsbuf) + 1); - - free( nsbuf ); } + // free(NULL) is defined to be OK too + free( nsbuf ); } } @@ -1706,7 +1706,7 @@ supersede: len = ip->client-> config->defaults[i].len + lease->options[i].len; - if (len > sizeof(dbuf)) { + if (len >= sizeof(dbuf)) { warning("no space to %s %s", "prepend option", dhcp_options[i].name);