From 5923d37e1f7d0ba3ccc5deaa6602c031913cc285 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Herm=C3=A8s=20B=C3=A9lusca-Ma=C3=AFto?= Date: Mon, 23 Mar 2026 13:27:25 +0100 Subject: [PATCH] [KDCOM][KDGDB] Fix kdcom.dll/kdgdb.dll file naming on MSVC-built ISOs CORE-20528 Addendum to commit 912c8ad987 (PR #5187) Fix a bug where "KDCOM/KDGDB_NAME_ON_CD" CMake variables weren't used as variables, but directly as names. --- drivers/base/kdcom/CMakeLists.txt | 2 +- drivers/base/kdgdb/CMakeLists.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/base/kdcom/CMakeLists.txt b/drivers/base/kdcom/CMakeLists.txt index 8ffc3f4127e..e33300f51b1 100644 --- a/drivers/base/kdcom/CMakeLists.txt +++ b/drivers/base/kdcom/CMakeLists.txt @@ -23,4 +23,4 @@ if(GDB) ## See PR #5187 else() set(KDCOM_NAME_ON_CD "$") endif() -add_cd_file(TARGET kdcom DESTINATION reactos/system32 NO_CAB NAME_ON_CD KDCOM_NAME_ON_CD FOR all) +add_cd_file(TARGET kdcom DESTINATION reactos/system32 NO_CAB NAME_ON_CD ${KDCOM_NAME_ON_CD} FOR all) diff --git a/drivers/base/kdgdb/CMakeLists.txt b/drivers/base/kdgdb/CMakeLists.txt index 96e0b78a123..12ac050b1bf 100644 --- a/drivers/base/kdgdb/CMakeLists.txt +++ b/drivers/base/kdgdb/CMakeLists.txt @@ -32,4 +32,4 @@ if(GDB) ## See PR #5187 else() set(KDGDB_NAME_ON_CD "$") endif() -add_cd_file(TARGET kdgdb DESTINATION reactos/system32 NO_CAB NAME_ON_CD KDGDB_NAME_ON_CD FOR all) +add_cd_file(TARGET kdgdb DESTINATION reactos/system32 NO_CAB NAME_ON_CD ${KDGDB_NAME_ON_CD} FOR all)