From 58695ec2725a883a1e292091f1d296cb41cf4752 Mon Sep 17 00:00:00 2001
From: Alex Ionescu <aionescu@gmail.com>
Date: Sat, 8 Jul 2006 19:41:20 +0000
Subject: [PATCH] - Write some TODOs. I'm now done with I/O IRP APIs and File
 Object handling. Let me know of regressions. - Next up... driver loading.

svn path=/trunk/; revision=22942
---
 reactos/ntoskrnl/io/iomgr/file.c   | 21 +++++++++++++++++++--
 reactos/ntoskrnl/io/iomgr/iofunc.c | 13 +++++++------
 2 files changed, 26 insertions(+), 8 deletions(-)

diff --git a/reactos/ntoskrnl/io/iomgr/file.c b/reactos/ntoskrnl/io/iomgr/file.c
index 67103f7c4c2..071e2286b2f 100644
--- a/reactos/ntoskrnl/io/iomgr/file.c
+++ b/reactos/ntoskrnl/io/iomgr/file.c
@@ -15,6 +15,25 @@
 #define NDEBUG
 #include <internal/debug.h>
 
+#if 0
+    IOTRACE(IO_IRP_DEBUG,
+            "%s - Queueing IRP %p\n",
+            __FUNCTION__,
+            Irp);
+#endif
+
+///
+//
+// TODO:
+// - Add support for Fast Dispatch I/O.
+// - Verify ShareAccess APIs, XP added some new semantics.
+// - Add Access Checks in IopParseDevice.
+// - Add validation checks in IoCreateFile.
+// - Add tracing.
+// - See why queueing IRPs and cancelling them causes crashes
+//
+///
+
 /* PRIVATE FUNCTIONS *********************************************************/
 
 NTSTATUS
@@ -1638,7 +1657,6 @@ IoUpdateShareAccess(IN PFILE_OBJECT FileObject,
     }
 }
 
-
 /*
  * @implemented
  */
@@ -1820,7 +1838,6 @@ IoSetFileOrigin(IN PFILE_OBJECT FileObject,
     return STATUS_NOT_IMPLEMENTED;
 }
 
-
 /*
  * @implemented
  */
diff --git a/reactos/ntoskrnl/io/iomgr/iofunc.c b/reactos/ntoskrnl/io/iomgr/iofunc.c
index 8bf50aa932d..623db0921d0 100644
--- a/reactos/ntoskrnl/io/iomgr/iofunc.c
+++ b/reactos/ntoskrnl/io/iomgr/iofunc.c
@@ -24,12 +24,13 @@
 ///
 //
 // TODO:
-// - Add SEH to some places where it's missing (MDLs, etc)
-// - Add a generic Cleanup/Exception Routine
-// - Add probe/alignment checks for Query/Set routines
-// - Add another parameter to IopCleanupFailedIrp
-// - Add support for Fast Dispatch I/O
-// - Add support for some fast-paths when querying/setting data
+// - Add SEH to some places where it's missing (MDLs, etc).
+// - Add a generic Cleanup/Exception Routine.
+// - Add probe/alignment checks for Query/Set routines.
+// - Add another parameter to IopCleanupFailedIrp.
+// - Add support for Fast Dispatch I/O.
+// - Add support for some fast-paths when querying/setting data.
+// - Add tracing.
 //
 ///