From 20e9adf4897941b314efe60d6f78775e6388fd49 Mon Sep 17 00:00:00 2001 From: Sylvain Petreolle Date: Sun, 17 Jan 2010 21:40:39 +0000 Subject: [PATCH] Add parameters check to ReadEventLog. Fixes last advapi32:eventlog crash svn path=/trunk/; revision=45125 --- reactos/dll/win32/advapi32/service/eventlog.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/reactos/dll/win32/advapi32/service/eventlog.c b/reactos/dll/win32/advapi32/service/eventlog.c index 7a4acb5cc07..23b138b5f13 100644 --- a/reactos/dll/win32/advapi32/service/eventlog.c +++ b/reactos/dll/win32/advapi32/service/eventlog.c @@ -673,6 +673,12 @@ ReadEventLogA(IN HANDLE hEventLog, hEventLog, dwReadFlags, dwRecordOffset, lpBuffer, nNumberOfBytesToRead, pnBytesRead, pnMinNumberOfBytesNeeded); + if(!pnBytesRead || !pnMinNumberOfBytesNeeded) + { + SetLastError(ERROR_INVALID_PARAMETER); + return FALSE; + } + /* If buffer is NULL set nNumberOfBytesToRead to 0 to prevent rpcrt4 from trying to access a null pointer */ if (!lpBuffer) @@ -737,6 +743,12 @@ ReadEventLogW(IN HANDLE hEventLog, hEventLog, dwReadFlags, dwRecordOffset, lpBuffer, nNumberOfBytesToRead, pnBytesRead, pnMinNumberOfBytesNeeded); + if(!pnBytesRead || !pnMinNumberOfBytesNeeded) + { + SetLastError(ERROR_INVALID_PARAMETER); + return FALSE; + } + /* If buffer is NULL set nNumberOfBytesToRead to 0 to prevent rpcrt4 from trying to access a null pointer */ if (!lpBuffer)