From 0f7db734e278499ff48cfd7dece4dfaa7f991b20 Mon Sep 17 00:00:00 2001 From: Aleksey Bragin Date: Fri, 2 Sep 2011 21:22:30 +0000 Subject: [PATCH] - Fix a totally broken case when a directory has no name in ObQueryNameString. Spotted by Coverity. svn path=/trunk/; revision=53535 --- reactos/ntoskrnl/ob/obname.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/reactos/ntoskrnl/ob/obname.c b/reactos/ntoskrnl/ob/obname.c index 6d0efd32695..f3a91e63dda 100644 --- a/reactos/ntoskrnl/ob/obname.c +++ b/reactos/ntoskrnl/ob/obname.c @@ -1126,8 +1126,11 @@ ObQueryNameString(IN PVOID Object, else { /* Directory without a name, we add "..." */ - ObjectName -= sizeof(L"..."); - ObjectName = L"..."; + ObjectName = (PWCH)((ULONG_PTR)ObjectName - + sizeof(L"...") + sizeof(UNICODE_NULL)); + RtlCopyMemory(ObjectName, + L"...", + sizeof(L"...") + sizeof(UNICODE_NULL)); break; } }